fix: display snowflake errors instead of closing modal #11009
Merged
+3
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -79,6 +80,7 @@ export function CreateOrUpdateConnectionSnowflakeModal({ | |||
| warehouse: "", | |||
| }); | |||
| _onSuccess(ds); | |||
| onClose(); | |||
There was a problem hiding this comment.
I guess here you'll want to add setIsOpen(false), no?
There was a problem hiding this comment.
No actually the setIsOpen was a mistake, removed
There was a problem hiding this comment.
just onClose does the trick 👍
There was a problem hiding this comment.
Oh, already done in onClose?
fontanierh
force-pushed
the
fix/dont-close-snowflake-modal-before-async-call
branch
from
9b5d1e9 to
7f1fd18
Compare
JulesBelveze
approved these changes
Feb 21, 2025
fontanierh
deleted the
fix/dont-close-snowflake-modal-before-async-call
branch
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We are closing the modal before the API call completes, so we're not displaying the error.
Tests
Manual
Risk
N/A
Deploy Plan
Deploy front