Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(sync): Do not sync note items when "sync notes" is disabled #608

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

dvanoni
Copy link
Owner

@dvanoni dvanoni commented Oct 17, 2024

Fixes #509

When note items were modified, they would be synced regardless of whether the "sync notes" option was enabled. This PR fixes that so that notes only sync:

  • when "sync notes" is enabled and a note item is modified, or
  • when a note item is specifically requested for sync via the context menu—regardless of the "sync notes" option

@dvanoni dvanoni linked an issue Oct 17, 2024 that may be closed by this pull request
Copy link
Contributor

🤖 Build Bot

✅ Successful build

⬇️ Download: notero-0.6.7-646

@dvanoni dvanoni merged commit 715e5a3 into main Oct 17, 2024
5 checks passed
@dvanoni dvanoni deleted the 509-unable-to-disable-syncing-notes branch October 17, 2024 05:11
@notero-bot notero-bot bot mentioned this pull request Oct 16, 2024
Copy link
Contributor

Included in release v0.6.7

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to disable Syncing Notes
1 participant