Skip to content
This repository has been archived by the owner on Sep 11, 2018. It is now read-only.

fix(main): specify .default property when importing RedBox using require() #896

Merged
merged 1 commit into from
Jun 30, 2016

Conversation

werelax
Copy link
Contributor

@werelax werelax commented Jun 30, 2016

Fix #888

@codecov-io
Copy link

Current coverage is 70.58%

Merging #896 into master will not change coverage

@@             master       #896   diff @@
==========================================
  Files            15         15          
  Lines            85         85          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits             60         60          
  Misses           25         25          
  Partials          0          0          

Powered by Codecov. Last updated by a8cef93...20c8078

@dvdzkwsk
Copy link
Owner

Wow was it seriously that simple? Can't believe I missed that... Thank you so much.

@dvdzkwsk dvdzkwsk merged commit 20c8078 into dvdzkwsk:master Jun 30, 2016
@dvdzkwsk
Copy link
Owner

🙇

@werelax
Copy link
Contributor Author

werelax commented Jun 30, 2016

Haha no problem. But now redbox-react is having some trouble unmounting. I've opened a PR to fix the issue there.

@werelax werelax deleted the fix/redbox-require branch July 1, 2016 11:59
@jnarowski
Copy link

Bravo, that's huge. Awesome work @werelax

@JMacLulich
Copy link

JMacLulich commented Jul 11, 2016

Just catching back up with this thread!

Wow, you mean to tell me all we had to do was to put default at the end and we get error messages rendered properly through hot reloading? Thanks so much @werelax this is going to save me so much of my life.

Can confirm I do get errors being passed up now!

They're still not particularly good, but that's just error reporting in general in React.

@dvdzkwsk
Copy link
Owner

@JMacLulich they should at least be a better with the new improvements in React 15.2.0 :)

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants