Improve error handling #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let me know anything I might've missed and take your time to review. |
dvishal485
approved these changes
Jun 4, 2023
dvishal485
approved these changes
Jun 4, 2023
|
Also, I think I removed context to some of the errors, they can be added back with |
dvishal485
approved these changes
Jun 4, 2023
|
Yeah, sure! Most errors handled manually were something for which the default error message generated should be enough! I appreciate your contribution to this repository and for taking out time for the same. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I have focused solely on making changes related to error handling.
We are utilizing
eyreinstead ofanyhowhere becauseeyreautomatically provides line and column information for errors. I haven't explored whether there is an effortless way to achieve the same withanyhowyet.