Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Mypy stub files for Cython files #1221

Open
arcondello opened this issue Jul 11, 2022 · 1 comment
Open

Mypy stub files for Cython files #1221

arcondello opened this issue Jul 11, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@arcondello
Copy link
Member

arcondello commented Jul 11, 2022 •
edited
Loading

It would be good to add stub files for some of the most commonly used cython packages because cython current does not support type annotations.

Especially dimod.cyvariables and dimod.cyutilities would benefit because the Variables object is used in many places.

Should be as simple as adding a dimod/cyvariables.pyi file etc.
@arcondello arcondello added the enhancement New feature or request label Jul 11, 2022
@arcondello
Copy link
Member Author

As a downside, it does not seem like those type annotations are picked up by sphinx (see sphinx-doc/sphinx#7630).

arcondello added a commit to arcondello/dimod that referenced this issue Jul 12, 2022
@arcondello
Add typing support to the Variables class
0319841 
See dwavesystems#1221
@arcondello arcondello mentioned this issue Jul 12, 2022
Merged
arcondello added a commit that referenced this issue Jul 18, 2022
@arcondello @JoelPasvolsky
Add typing support to the Variables class (#1223)
0d69a74 
* Add typing support to the Variables class

See #1221

Co-authored-by: Joel <34041130+JoelPasvolsky@users.noreply.github.com>
@randomir randomir mentioned this issue Sep 14, 2022
Merged
arcondello added a commit that referenced this issue Oct 27, 2022
@arcondello
Remove constraint/*.pyi stubs
b1d8d6c 
They were not yet filled out, we should restore them at some point
as part of #1221
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@arcondello