Conversion PHPUnit into Kahlan test #17
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MarikaBBB next steps:
|
MarikaBBB
force-pushed
the
terstConversion
branch
2 times, most recently
from
c417556 to
c13a720
Compare
snim2
reviewed
Jan 28, 2025
spec/UseAtomSpec.php
Outdated
| use Dxw\Iguana\Extras\UseAtom; | ||
|
|
||
| describe('UseAtom', function () { | ||
| // initialisation |
snim2
reviewed
Jan 28, 2025
spec/UseAtomSpec.php
Outdated
|
|
||
| }); | ||
|
|
||
| afterEach(function () { |
There was a problem hiding this comment.
I think we probably don't need this afterEach, see what happens if you remove it
snim2
reviewed
Jan 28, 2025
|
|
||
|
|
||
|
|
||
| // Check that this code runs to completion without errors |
There was a problem hiding this comment.
We can remove the check that the code runs to completion because we've used expect() here
snim2
reviewed
Jan 28, 2025
CHANGELOG.md
Outdated
| @@ -13,3 +13,13 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
| ## [Earlier Releases] | |||
|
|
|||
| Releases up to and including v1.0.0 predate this changelog, but see the [README](README.md) for summary of functionality. | |||
|
|
|||
| ## 2025-01-17 | |||
There was a problem hiding this comment.
Here we can say ## [Unreleased]
Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v3...v4) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
MarikaBBB
force-pushed
the
terstConversion
branch
from
3f4fede to
72b26eb
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
use_atom_test.phpto Kahaln , removingWP_Mockdependencies.phpunit/phpunittokahlan/kahlan: ^6.0in composer.json and CI configuration. This ensure that only tests written in Kahlan will run after this PR is merged.Testing instructions:
composer install/vendor/bin/kahlanfor testing.