-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[CORE-852] Re-add Rosetta cmd #1002
Conversation
WalkthroughThe update to the codebase introduces the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files ignored due to path filters (2)
protocol/go.mod
is excluded by:!**/*.mod
protocol/go.sum
is excluded by:!**/*.sum
Files selected for processing (1)
- protocol/cmd/dydxprotocold/cmd/root.go (2 hunks)
Additional comments: 2
protocol/cmd/dydxprotocold/cmd/root.go (2)
- 40-40: Import of
rosettaCmd
package added.- 228-228: Integration of
RosettaCommand
intoinitRootCmd
.
Example output from cmd line: ``` protocol % ./build/dydxprotocold rosetta --help spin up a rosetta server Usage: dydxprotocold rosetta [flags] Flags: --addr string the address rosetta will bind to (default ":8080") --blockchain string the blockchain type (default "app") --denom-to-suggest string default denom for fee suggestion (default "uatom") --enable-fee-suggestion enable default fee suggestion --gas-to-suggest int default gas for fee suggestion (default 200000) --grpc string the app gRPC endpoint (default "localhost:9090") --grpc-types-server string the app gRPC Server endpoint for proto messages types and reflection -h, --help help for rosetta --network string the network name (default "network") --offline run rosetta only with construction API --plugin string plugin folder name (default "cosmos-hub") --prices-to-suggest string default prices for fee suggestion (default "1uatom,1stake") --retries int the number of retries that will be done before quitting (default 5) --tendermint string the CometBFT rpc endpoint, without tcp:// (default "localhost:26657") Global Flags: --home string directory for config and data (default "/Users/lcwik/.dydxprotocol") --log_format string The logging format (json|plain) (default "plain") --log_level string The logging level (trace|debug|info|warn|error|fatal|panic|disabled or '*:<level>,<key>:<level>') (default "info") --log_no_color Disable colored logs --trace print out full stack trace on errors ```
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files ignored due to path filters (2)
protocol/go.mod
is excluded by:!**/*.mod
protocol/go.sum
is excluded by:!**/*.sum
Files selected for processing (1)
- protocol/cmd/dydxprotocold/cmd/root.go (2 hunks)
Files skipped from review as they are similar to previous changes (1)
- protocol/cmd/dydxprotocold/cmd/root.go
Changelist
[CORE-852] Re-add Rosetta cmd
Example output from cmd line:
Test Plan
Manually tested.
Author/Reviewer Checklist
state-breaking
label.indexer-postgres-breaking
label.PrepareProposal
orProcessProposal
, manually add the labelproposal-breaking
.feature:[feature-name]
.backport/[branch-name]
.refactor
,chore
,bug
.