Disable MsgCancelProposal
#1015
Conversation
WalkthroughThe recent modifications involve shifting Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 1
Configuration used: CodeRabbit UI
Files selected for processing (4)
- protocol/app/msgs/normal_msgs.go (1 hunks)
- protocol/app/msgs/normal_msgs_test.go (1 hunks)
- protocol/app/msgs/unsupported_msgs.go (2 hunks)
- protocol/app/msgs/unsupported_msgs_test.go (1 hunks)
Files skipped from review due to trivial changes (1)
- protocol/app/msgs/normal_msgs_test.go
Additional comments: 2
protocol/app/msgs/unsupported_msgs_test.go (1)
- 14-15: The addition of
"/cosmos.gov.v1.MsgCancelProposal"and"/cosmos.gov.v1.MsgCancelProposalResponse"to the expected message list inTestUnsupportedMsgSamples_Keycorrectly reflects the PR's objective to mark these messages as unsupported. This change ensures that the test aligns with the updated protocol behavior.protocol/app/msgs/unsupported_msgs.go (1)
- 5-5: The import of the
govpackage fromgithub.heygears.com/cosmos/cosmos-sdk/x/gov/types/v1is correctly added to support the declaration ofMsgCancelProposalandMsgCancelProposalResponseas unsupported messages. This change is necessary for the implementation of the PR's objectives.
| // MsgCancelProposal is not allowed by protocol, due to it's potential for abuse. | ||
| "/cosmos.gov.v1.MsgCancelProposal": &gov.MsgCancelProposal{}, | ||
| "/cosmos.gov.v1.MsgCancelProposalResponse": nil, | ||
| // These are deprecated/legacy msgs that we should not support. |
There was a problem hiding this comment.
The declarations for "/cosmos.gov.v1.MsgCancelProposal" and "/cosmos.gov.v1.MsgCancelProposalResponse" as unsupported messages are correctly implemented. This aligns with the PR's objective to disable these message types. However, setting the MsgCancelProposalResponse to nil might not be the best approach if the intention is to explicitly mark it as unsupported. Consider providing a stub or a specific unsupported message response to handle any potential calls to this message type more gracefully.
- "/cosmos.gov.v1.MsgCancelProposalResponse": nil,
+ "/cosmos.gov.v1.MsgCancelProposalResponse": &gov.MsgCancelProposalResponse{ /* fields if necessary */ },Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| // MsgCancelProposal is not allowed by protocol, due to it's potential for abuse. | |
| "/cosmos.gov.v1.MsgCancelProposal": &gov.MsgCancelProposal{}, | |
| "/cosmos.gov.v1.MsgCancelProposalResponse": nil, | |
| // These are deprecated/legacy msgs that we should not support. | |
| // MsgCancelProposal is not allowed by protocol, due to it's potential for abuse. | |
| "/cosmos.gov.v1.MsgCancelProposal": &gov.MsgCancelProposal{}, | |
| "/cosmos.gov.v1.MsgCancelProposalResponse": &gov.MsgCancelProposalResponse{ /* fields if necessary */ }, | |
| // These are deprecated/legacy msgs that we should not support. |
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- protocol/lib/ante/unsupported_msgs.go (2 hunks)
Additional comments: 2
protocol/lib/ante/unsupported_msgs.go (2)
- 5-5: The addition of the
govpackage import fromgithub.heygears.com/cosmos/cosmos-sdk/x/gov/types/v1is correctly aligned with the PR's objective to handleMsgCancelProposalas an unsupported message. This change is necessary for the subsequent logic that checks forgov.MsgCancelProposaltype in theIsUnsupportedMsgfunction.- 20-21: The modification to include
*gov.MsgCancelProposalin theIsUnsupportedMsgfunction's case statement effectively marksMsgCancelProposalas unsupported, aligning with the PR's objectives. This change is straightforward and correctly implements the logic to identifyMsgCancelProposalas an unsupported message type. However, ensure that all references and usages ofMsgCancelProposalthroughout the codebase have been updated to reflect this change.
Changelist
MsgCancelProposalwhich was a new message introduced in Cosmos SDK 0.50 (Context here)Test Plan
Author/Reviewer Checklist
state-breakinglabel.indexer-postgres-breakinglabel.PrepareProposalorProcessProposal, manually add the labelproposal-breaking.feature:[feature-name].backport/[branch-name].refactor,chore,bug.