[CORE-538] Have testing genesis.sh match expected gov parameters for 0.50 #935
Conversation
WalkthroughThe update to the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files ignored due to filter (1)
- protocol/scripts/genesis/sample_pregenesis.json
Files selected for processing (1)
- protocol/testing/genesis.sh (1 hunks)
Additional comments: 2
protocol/testing/genesis.sh (2)
87-99: The changes to the
edit_genesisfunction include setting the native token denomination for thegovmodule, adjusting deposit and voting periods, setting the initial deposit ratio, disabling proposal cancellation, and modifying the threshold for expedited proposal approval. Ensure that these values are consistent with the intended governance parameters and that the syntax for thedaselcommands is correct.102-102: The
unbonding_timefor thestakingmodule is set to 21 days (1814400s). Confirm that this duration aligns with the governance policies and that the value is correctly formatted in seconds.
protocol/testing/genesis.sh
Outdated
| @@ -85,13 +85,18 @@ function edit_genesis() { | |||
|
|
|||
| # Update gov module. | |||
| dasel put -t string -f "$GENESIS" '.app_state.gov.params.min_deposit.[0].denom' -v "$NATIVE_TOKEN" | |||
| dasel put -t string -f "$GENESIS" '.app_state.gov.params.expedited_min_deposit.[0].denom' -v "$NATIVE_TOKEN" | |||
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- protocol/testing/genesis.sh (1 hunks)
Additional comments: 8
protocol/testing/genesis.sh (8)
- 88-88: The addition of the
expedited_min_depositparameter with the native token denomination aligns with the PR objectives to update governance parameters.- 89-89: The reduction of the
max_deposit_periodto '300s' is consistent with the PR's aim to adjust governance parameters.- 90-90: Setting the
expedited_voting_periodto '60s' is in line with the intended changes to governance parameters.- 91-91: Adjusting the
voting_periodto '300s' matches the PR's goal to modify governance module parameters.- 92-92: The
min_initial_deposit_ratiois set to '0.20000', which is intended to prevent spamming by requiring a 20% initial deposit, aligning with the PR objectives.- 97-97: Setting the
proposal_cancel_ratioto '1' effectively disables proposal cancellation, which is a deliberate change according to the PR description.- 99-99: The
expedited_thresholdis set to '0.75000', meaning a 75% vote requirement for expedited proposals to pass, which is consistent with the PR's changes.- 100-100: Updating the
unbonding_timein the staking module to '1814400s' (21 days) is in accordance with the PR's objectives to adjust staking parameters.
Changelist
[CORE-538] Have testing genesis.sh match expected gov parameters for 0.50
Test Plan
Updated existing test result
Author/Reviewer Checklist
state-breakinglabel.indexer-postgres-breakinglabel.PrepareProposalorProcessProposal, manually add the labelproposal-breaking.feature:[feature-name].backport/[branch-name].refactor,chore,bug.