Remove first block from aggregate trading rewards roundtable task interval

[Christopher-Li]

Changelist

Remove first block from aggregate trading rewards roundtable task interval. Turns the block time for the genesis block can be years ago. We don't need to calculate from the first block ever, we can just wait for the first trading reward to calculate aggregations.

Test Plan

Tested in staging, and works

Author/Reviewer Checklist

• If this PR has changes that result in a different app state given the same prior state and transaction list, manually add the state-breaking label.
• If the PR has breaking postgres changes to the indexer add the indexer-postgres-breaking label.
• If this PR isn't state-breaking but has changes that modify behavior in PrepareProposal or ProcessProposal, manually add the label proposal-breaking.
• If this PR is one of many that implement a specific feature, manually label them all feature:[feature-name].
• If you wish to for mergify-bot to automatically create a PR to backport your change to a release branch, manually add the label backport/[branch-name].
• Manually add any of the following labels: refactor, chore, bug.

[coderabbitai]

Walkthrough

The overall change entails updating the logging functionality within the AggregateTradingReward class. Specifically, the period property has been added to the information output by several logger.info calls, which will enhance the traceability and context of the logs by including the time period associated with the trading rewards being aggregated.

Changes

File Path	Change Summary
.../aggregate-trading-rewards.ts	Added period: this.period to logger.info calls in AggregateTradingReward class.
.../aggregate-trading-rewards.test.ts	Unable to modify tests as requested.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 0dc4960 and 34f5e32.

Files selected for processing (2)

• indexer/services/roundtable/tests/tasks/aggregate-trading-rewards.test.ts (3 hunks)
• indexer/services/roundtable/src/tasks/aggregate-trading-rewards.ts (14 hunks)

Additional comments: 14

indexer/services/roundtable/src/tasks/aggregate-trading-rewards.ts (14)

• 74-74: The addition of period: this.period to the logger.info call provides more context for the logging, which aligns with the PR objectives to enhance logging for clarity in the aggregation process.

• 130-130: The addition of period: this.period to the logger.info call within the deleteIncompleteAggregatedTradingReward method is consistent with the other logging improvements and provides useful context.

• 139-139: The logging statement here has been enhanced with additional context (period, height, time), which is beneficial for tracking the deletion of aggregated trading rewards.

• 164-164: The addition of period: this.period to the logger.info call within the getTradingRewardDataToProcessInterval method is consistent with the other logging improvements and provides useful context.

• 201-206: The error logging here is crucial as it indicates a serious issue if there are no trading rewards in the database. The inclusion of period: this.period in the log provides necessary context for troubleshooting.

• 304-304: The addition of period: this.period to the logger.info call within the updateTradingRewardsAggregation method is consistent with the other logging improvements and provides useful context.

• 313-313: The logging statement here has been enhanced with additional context (period, error, start, end), which is beneficial for tracking the failure in updating trading rewards aggregation.

• 490-490: The addition of period: this.period to the logger.info call within the createAndUpdateAggregations method is consistent with the other logging improvements and provides useful context.

• 506-506: The logging statement here has been enhanced with additional context (period, count), which is beneficial for tracking the creation of trading reward aggregations.

• 519-519: The addition of period: this.period to the logger.info call within the createAndUpdateAggregations method is consistent with the other logging improvements and provides useful context.

• 535-535: The logging statement here has been enhanced with additional context (period, count), which is beneficial for tracking the update of trading reward aggregations.

• 545-545: The addition of period: this.period to the logger.info call within the setProcessedTime method is consistent with the other logging improvements and provides useful context.

• 556-556: The logging statement here has been enhanced with additional context (period, processedTime), which is beneficial for tracking the setting of processed time in the cache.

• 392-392: The error logging here is crucial as it indicates a serious issue if no blocks are found after a certain time. The inclusion of period: this.period in the log provides necessary context for troubleshooting.