feat(sequencer): added reward addr and whitelisted relayers #1313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omritoptix
reviewed
Oct 12, 2024
| } | ||
| } | ||
|
|
||
| err = ValidateWhitelistedRelayers(msg.WhitelistedRelayers) |
There was a problem hiding this comment.
I think we should limit the list of relayer addresses. 10 should be more than enough.
|
the task is suspended until the RollApp-Hub sync ADR is ready. |
omritoptix
reviewed
Oct 28, 2024
| @@ -17,4 +16,30 @@ message EventIncreasedBond { | |||
| cosmos.base.v1beta1.Coin added_amount = 2 [(gogoproto.nullable) = false]; | |||
| // bond is the new active bond amount of the sequencer | |||
| repeated cosmos.base.v1beta1.Coin bond = 3 [(gogoproto.nullable) = false, (gogoproto.castrepeated) = "github.com/cosmos/cosmos-sdk/types.Coins"]; | |||
| } | |||
|
|
|||
| message EventRotationStarted { | |||
There was a problem hiding this comment.
this is probably redundant with current polling
omritoptix
approved these changes
Oct 29, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ADR link https://www.notion.so/dymension/ADR-Whitelisted-Relayer-Fee-Exemption-in-Rollapp-104a4a51f86a80e8ad94c916c87deb17
Closes #1226
Closes #XXX
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow-up issues.
PR review checkboxes:
I have...
Unreleasedsection inCHANGELOG.mdgodoccommentsSDK Checklist
maptime.Now()sendCoinand notSendCoinsFull security checklist here
For Reviewer:
After reviewer approval: