Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Bonded Sequencer event is Redundant #1153

Closed
1 task done
omritoptix opened this issue Oct 20, 2024 · 1 comment
Closed
1 task done

Bonded Sequencer event is Redundant #1153

omritoptix opened this issue Oct 20, 2024 · 1 comment
Assignees

Comments

@omritoptix
Copy link
Contributor

omritoptix commented Oct 20, 2024

I blv we should get rid of the new bonded sequencer event as after will change to polling every small interval, and also we require to be in sync with current sequencers for their pub-key just before the rotation (assuming an event can be missed, we must query the sequencers list just before the rotation to validate polling didn’t miss anything), the event is not really adding anything meaningful to be kept

// listen to new bonded sequencers events to add them in the sequencer set
	go uevent.MustSubscribe(ctx, m.Pubsub, "newBondedSequencer", settlement.EventQueryNewBondedSequencer, m.UpdateSequencerSet, m.logger)

blocked by:

@danwt
Copy link
Contributor

danwt commented Jan 7, 2025

Closing because of #1144
Please could you confirm it's OK to close @keruch ?
Thanks

@danwt danwt closed this as completed Jan 7, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants