Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: added sequencer set polling and consensus msgs queue #1144

Merged
merged 57 commits into from
Oct 28, 2024

Conversation

keruch
Copy link
Contributor

@keruch keruch commented Oct 16, 2024

PR Standards

ADR links

  1. https://www.notion.so/dymension/ADR-x-Sequencer-Reward-Address-On-Rollapp-da84af6888c141d0a4c1a8df256a5025
  2. https://www.notion.so/dymension/ADR-Whitelisted-Relayer-Fee-Exemption-in-Rollapp-104a4a51f86a80e8ad94c916c87deb17

Closes
dymensionxyz/dymension#1248
dymensionxyz/dymension#1226
#1153
#1125

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@keruch keruch changed the base branch from main to kirill/1149-seq-set-decoupling October 24, 2024 19:34
@keruch keruch marked this pull request as ready for review October 25, 2024 12:44
@keruch keruch requested a review from omritoptix October 25, 2024 12:44
omritoptix
omritoptix previously approved these changes Oct 27, 2024
Base automatically changed from kirill/1149-seq-set-decoupling to main October 28, 2024 18:05
@omritoptix omritoptix dismissed their stale review October 28, 2024 18:05

The base branch was changed.

@omritoptix omritoptix merged commit 504523b into main Oct 28, 2024
6 checks passed
@omritoptix omritoptix deleted the kirill/1226-hub-polling branch October 28, 2024 20:29
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants