Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: sequencer whitelisted relayers #1133

Conversation

keruch
Copy link
Contributor

@keruch keruch commented Oct 11, 2024

PR Standards

Opening a pull request should be able to meet the following requirements

--

PR naming convention: https://hackmd.io/@nZpxHZ0CT7O5ngTp0TP9mg/HJP_jrm7A


Close #XXX

<-- Briefly describe the content of this pull request -->

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@keruch keruch self-assigned this Oct 11, 2024
proposerHashForBlock = nextProposerInfo.nextProposerHash
nextProposerAddr = nextProposerInfo.nextProposerAddr
proposerHashForBlock = nextProposer.Hash
nextProposerAddr = nextProposer.Address
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NextProposerAddr is confusing cause in dymint world it refers to the dymint pubkeyAddr but we're actually refering to the App Addr here.

@keruch
Copy link
Contributor Author

keruch commented Oct 15, 2024

the task is suspended until the RollApp-Hub ADR is ready.

@keruch keruch closed this Oct 16, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants