Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(settlement): use block descriptors as source of truth for blocks to apply #1172

Merged
merged 4 commits into from
Oct 28, 2024

Conversation

srene
Copy link
Contributor

@srene srene commented Oct 28, 2024

PR Standards

Opening a pull request should be able to meet the following requirements

--

PR naming convention: https://hackmd.io/@nZpxHZ0CT7O5ngTp0TP9mg/HJP_jrm7A


Close #1169

<-- Briefly describe the content of this pull request -->

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@srene srene self-assigned this Oct 28, 2024
@srene srene requested a review from a team as a code owner October 28, 2024 13:56
@srene srene marked this pull request as draft October 28, 2024 13:56
@srene srene marked this pull request as ready for review October 28, 2024 14:17
omritoptix
omritoptix previously approved these changes Oct 28, 2024
Copy link
Contributor

@omritoptix omritoptix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved with small suggestion

@omritoptix omritoptix dismissed their stale review October 28, 2024 15:50

possible problem with block index

@omritoptix omritoptix changed the title fix(settlement): only apply blocks from da that are included in state update block descriptors fix(settlement): use block descriptors as source of truth for blocks to apply Oct 28, 2024
@omritoptix omritoptix merged commit 4e23fdb into main Oct 28, 2024
6 checks passed
@omritoptix omritoptix deleted the srene/1169-follow-bds-syncing branch October 28, 2024 20:37
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make sure block descriptors is the source of truth when applying and validating
2 participants