Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix(manager): removed redundant validation err check #1177

Merged
merged 1 commit into from
Oct 30, 2024
Merged

fix(manager): removed redundant validation err check #1177

merged 1 commit into from
Oct 30, 2024

Conversation

omritoptix
Copy link
Contributor

PR Standards

Opening a pull request should be able to meet the following requirements

--

PR naming convention: https://hackmd.io/@nZpxHZ0CT7O5ngTp0TP9mg/HJP_jrm7A

Close #XXX

<-- Briefly describe the content of this pull request -->

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@omritoptix omritoptix requested a review from a team as a code owner October 29, 2024 10:36
@mtsitrin mtsitrin merged commit 7326b64 into main Oct 30, 2024
7 checks passed
@mtsitrin mtsitrin deleted the omritoptix/removed-redundant-err-check branch October 30, 2024 08:17
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@mtsitrin mtsitrin mtsitrin approved these changes

Assignees
No one assigned
Labels
dym-internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@omritoptix @mtsitrin