Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix(sync): fixed proposer by height syncing issue on startup and rotation #1189

Merged
merged 10 commits into from
Nov 4, 2024
Merged

fix(sync): fixed proposer by height syncing issue on startup and rotation #1189

merged 10 commits into from
Nov 4, 2024

Conversation

omritoptix
Copy link
Contributor

PR Standards

Opening a pull request should be able to meet the following requirements

--

PR naming convention: https://hackmd.io/@nZpxHZ0CT7O5ngTp0TP9mg/HJP_jrm7A

Close #XXX

<-- Briefly describe the content of this pull request -->

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@omritoptix omritoptix requested a review from a team as a code owner October 30, 2024 17:06
This was linked to issues Oct 30, 2024
Problem Syncing When Chain is halted #1150
Closed
Get proposer should get proposer by height #1184
Closed
Base automatically changed from omritoptix/cleanup-proposer-full-node-rotation-flows to main October 31, 2024 11:45
srene
srene reviewed Oct 31, 2024
View reviewed changes
@omritoptix omritoptix marked this pull request as draft October 31, 2024 15:14
@omritoptix omritoptix marked this pull request as ready for review October 31, 2024 15:44
@omritoptix omritoptix merged commit 5878792 into main Nov 4, 2024
6 checks passed
@omritoptix omritoptix deleted the omritoptix/1184-get-proposer-by-height-syncing-issue branch November 4, 2024 09:10
@omritoptix omritoptix linked an issue Nov 5, 2024 that may be closed by this pull request
Getting operator on init chainer can cause non determinsm #1137
Closed
mtsitrin pushed a commit that referenced this pull request Nov 7, 2024
@omritoptix @srene @mtsitrin
fix(sync): fixed proposer by height syncing issue on startup and rota…
d63e828 
…tion (#1189)

Co-authored-by: Sergi Rene <sergi@dymension.xyz>
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@srene srene srene approved these changes

Assignees
No one assigned
Labels
dym-internal
Projects
None yet
Milestone
No milestone
2 participants
@omritoptix @srene