Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: get revision for height instead of the latest #1249

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

keruch
Copy link
Contributor

@keruch keruch commented Nov 20, 2024

PR Standards

Opening a pull request should be able to meet the following requirements

--

PR naming convention: https://hackmd.io/@nZpxHZ0CT7O5ngTp0TP9mg/HJP_jrm7A


Close #XXX

<-- Briefly describe the content of this pull request -->

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@keruch keruch requested a review from srene November 20, 2024 12:16
@keruch keruch self-assigned this Nov 20, 2024
@keruch keruch requested a review from a team as a code owner November 20, 2024 12:16
@keruch
Copy link
Contributor Author

keruch commented Nov 20, 2024

cherry pick of cebc174

@srene srene merged commit f503231 into main Nov 21, 2024
5 checks passed
@srene srene deleted the kirill/multiple-revisions-2 branch November 21, 2024 09:02
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants