Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat(block): removes evidence list, intermediate roots from block #1317

Merged
merged 4 commits into from
Jan 9, 2025
Merged

feat(block): removes evidence list, intermediate roots from block #1317

merged 4 commits into from
Jan 9, 2025

Conversation

danwt
Copy link
Contributor

@danwt danwt commented Jan 8, 2025

PR Standards

Opening a pull request should be able to meet the following requirements

--

PR naming convention: https://hackmd.io/@nZpxHZ0CT7O5ngTp0TP9mg/HJP_jrm7A

Close #XXX

<-- Briefly describe the content of this pull request -->

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@danwt danwt requested a review from a team as a code owner January 8, 2025 19:19
@danwt danwt changed the title danwt: removes evidence list, intermediate roots feat(block): removes evidence list, intermediate roots from block Jan 8, 2025
mtsitrin
mtsitrin previously approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@mtsitrin mtsitrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great cleanup

@mtsitrin mtsitrin merged commit 132f916 into main Jan 9, 2025
4 checks passed
@mtsitrin mtsitrin deleted the danwt/1101-remove-evidence-intermediate-roots branch January 9, 2025 10:00
@mtsitrin mtsitrin linked an issue Jan 14, 2025 that may be closed by this pull request
Obsolete evidence data and intermediate roots #1101
Closed
srene pushed a commit that referenced this pull request Feb 17, 2025
@danwt @srene
feat(block): removes evidence list, intermediate roots from block (#1317
0e4d08f 
)
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@mtsitrin mtsitrin mtsitrin left review comments

Assignees
No one assigned
Labels
dym-internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Obsolete evidence data and intermediate roots
2 participants
@danwt @mtsitrin