Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Support MSYS2/mingw-w64 #113

Merged
merged 2 commits into from
Dec 9, 2020
Merged

Support MSYS2/mingw-w64 #113

merged 2 commits into from
Dec 9, 2020

Conversation

mingwandroid
Copy link
Contributor

@mingwandroid mingwandroid commented Dec 1, 2020 •
edited
Loading

Switching from $dayjob to $other-opensource-stuff .. this allows building on MSYS2/mingw-w64. I plan to submit a PR soon to MSYS2 for inclusion.

Thanks for your kind reviews!

@mingwandroid
Copy link
Contributor Author

Oh, the failure we avoid here is:

/bin/sh ../libtool  --tag=CC --tag=disable-static  --mode=link gcc -I/c/opt/r/w/mingw-w64-frei0r-plugins/src/frei0r-plugins-1.7.0/include -Waddress -Wtype-limits -Wsign-compare -march=x86-64 -mtune=generic -O2 -pipe -module -avoid-version -lm -export-dynamic -pipe -Wl,--dynamicbase,--high-entropy-va,--nxcompat,--default-image-base-high -o alphainjection.la -rpath /mingw64/lib/frei0r-1 mixer2/alphainjection/alphainjection.lo
/bin/sh ../libtool  --tag=CXX --tag=disable-static  --mode=link g++  -march=x86-64 -mtune=generic -O2 -pipe -module -avoid-version -lm -export-dynamic -pipe -Wl,--dynamicbase,--high-entropy-va,--nxcompat,--default-image-base-high -o alphaout.la -rpath /mingw64/lib/frei0r-1 mixer2/alphaout/alphaout.lo
libtool:   error: can't build x86_64-w64-mingw32 shared library unless -no-undefined is specified

@ddennedy
Copy link
Collaborator

ddennedy commented Dec 1, 2020 •
edited
Loading

FYI, CMake works for me in msys2.

@mingwandroid
Copy link
Contributor Author

Sure, that's great, but I'd like to use autotools personally!

@mingwandroid
Copy link
Contributor Author

This isn't quite ready yet.

@mingwandroid
Copy link
Contributor Author

I think this is ready for review now.

ddennedy
ddennedy reviewed Dec 2, 2020
View reviewed changes
.github/workflows/ci-build.sh Outdated Show resolved Hide resolved
.github/workflows/ci-build.sh Outdated Show resolved Hide resolved
.github/workflows/ci-build.sh Outdated Show resolved Hide resolved
@mingwandroid
Copy link
Contributor Author

Here is my PR to add frei0r to MSYS2: msys2/MINGW-packages#7367

@lazka
Copy link

lazka commented Dec 2, 2020 •
edited
Loading

What's the point of adding our CI scripts here? Are there any PKGBUILDs?

See for example https://github.com/harfbuzz/harfbuzz/blob/master/.github/workflows/msys2-ci.yml how to add MSYS2 CI

@mingwandroid
Copy link
Contributor Author

Thanks. I'll read up and fix it. I'll also split adding ci into a separate pr.

@mingwandroid
Fix out-of-source-tree CXX build failures
4e7e0f4 
Lack of CXXFLAGS here. I would expect that CPPFLAGS would
have made it through but that seems not to be the case.

Anyway it seems like being able to specify global CXXFLAGS
in one place is useful and this achieves that too.
@mingwandroid
Support MSYS2/mingw-w64
be4dcc6
@mingwandroid
Copy link
Contributor Author

Hi @ddennedy, I removed all the GitHub actions stuff from this PR and think the rest is ready for a re-review if you had time?

@ddennedy ddennedy merged commit 86475d3 into dyne:master Dec 9, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ddennedy ddennedy ddennedy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mingwandroid @ddennedy @lazka