Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add an example for testing symtab api support #27

Closed
wants to merge 1 commit into from

Conversation

bbiiggppiigg
Copy link
Contributor

No description provided.

@hainest
Copy link
Collaborator

hainest commented Jan 21, 2022

Is this meant to be an example or a test? Everything but the filename suggests it's an example. It looks like this code was lifted directly from https://github.com/dyninst/examples/blob/master/disassemble/disassemble.cpp. Indeed, the code for disassemble is commented out at the bottom (which should be removed).

It appears this is trying to show some line info and mangled names using the module class. Is there something more specific?

@bbiiggppiigg
Copy link
Contributor Author

bbiiggppiigg commented Jan 21, 2022

Yeah this is suppose to be an example. Sorry about the confusing naming.
I was trying to build an example / application that tests the coverage of SymtabAPI for AMDGPU, figure might as well add it to the example repo.

The example is not really done yet, the goal is to call each member method of each class,
so it can be an example of how to use SymtabAPI as well as a tool for testing coverage.

Ideally, this example will grow as I add more support for AMDGPU and thus need more testing.

@hainest
Copy link
Collaborator

hainest commented Jan 21, 2022

The example is not really done yet, the goal is to call each member method of each class

This is a good test to make sure that all member functions actually work. I've cleaned up several classes where some member functions had no implementation. Having an example usage for all member functions in Symtab would be great. Thanks for putting this together!

@hainest hainest mentioned this pull request Jan 21, 2024
@hainest
Copy link
Collaborator

hainest commented Jan 21, 2024

Replaced by #50.

@hainest hainest closed this Jan 21, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants