Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add patchAPI #46

Merged
merged 1 commit into from
Jan 8, 2024
Merged

Add patchAPI #46

merged 1 commit into from
Jan 8, 2024

Conversation

hainest
Copy link
Collaborator

@hainest hainest commented Jan 6, 2024

PatchModifier causes a crash in Dyninst. It looks to be a runaway boost::recursive_lock. I'll post an issue in the main repo.

@hainest hainest requested a review from kupsch January 6, 2024 05:14
@hainest hainest self-assigned this Jan 6, 2024
Copy link
Contributor

@kupsch kupsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does addressSpace library exist just to validate the PatchAPI::AddrSpace interface?

@hainest
Copy link
Collaborator Author

hainest commented Jan 8, 2024

Does addressSpace library exist just to validate the PatchAPI::AddrSpace interface?

It's a version of the example in the old docs that actually compiles. It necessarily checks the interface, but it exists in its current form because I couldn't find a usage in Dyninst to make it into a runnable example.

@hainest hainest merged commit a468d64 into master Jan 8, 2024
1 check passed
@hainest hainest deleted the thaines/patchAPI branch January 8, 2024 18:52
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants