Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Locked questionnaires failing in editor form #1479

Closed
janno42 opened this issue Jun 5, 2020 · 0 comments · Fixed by #1484
Closed

Locked questionnaires failing in editor form #1479

janno42 opened this issue Jun 5, 2020 · 0 comments · Fixed by #1484
Assignees
Labels
[C] Backend Focuses on backend implementation [C] Tests and CI New or better testing and CI [P] Major Major priority [S] Small This issue should require only small changes. [T] Bug This is a bug. We don't like it. Please get rid of it.
Milestone

Comments

@janno42
Copy link
Member

janno42 commented Jun 5, 2020

#1445 introduced locked questionnaires. However, they are not dealt with correctly in the evaluation editor form. When initially opening the form, the locked questionnaires are correctly selected but are not handled correctly when saving the form.

Steps to reproduce:

  1. As manager, assign a locked questionnaire as the only general questionnaire for an evaluation.
  2. Enable the evaluation for editor review.
  3. As editor, open the evaluation form and try to save it. Saving will fail with an error for the field "General questionnaires" ("This field is required.").

The locked questionnaire should count as a selected questionnaire and the form should be saved.
A test should be added for this use case.

@janno42 janno42 added [C] Backend Focuses on backend implementation [P] Major Major priority [S] Small This issue should require only small changes. [C] Tests and CI New or better testing and CI [T] Bug This is a bug. We don't like it. Please get rid of it. labels Jun 5, 2020
@janno42 janno42 added this to the Summer 2020 milestone Jun 5, 2020
@janno42 janno42 self-assigned this Jun 9, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
[C] Backend Focuses on backend implementation [C] Tests and CI New or better testing and CI [P] Major Major priority [S] Small This issue should require only small changes. [T] Bug This is a bug. We don't like it. Please get rid of it.
Development

Successfully merging a pull request may close this issue.

1 participant