Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Pause background state machine when purging existing logs #663

Closed
wants to merge 2 commits into from

Conversation

Besroy
Copy link
Contributor

@Besroy Besroy commented Mar 17, 2025

When baseline re-sync is triggered, the background commit thread may execute simultaneously. If the baseline re-sync purges all logs, the commit thread cannot fetch any logs to commit. This change pauses the commit during log purging to prevent the commit thread from accessing non-existent logs.

More details in issue37

When baseline re-sync is triggered, the background commit thread may execute simultaneously.
If the baseline re-sync purges all logs, the commit thread cannot fetch any logs to commit.
This change pauses the commit during log purging to prevent the commit thread from accessing non-existent logs.
@Besroy Besroy requested review from xiaoxichen, koujl and yuwmao March 17, 2025 06:44
@codecov-commenter
Copy link

codecov-commenter commented Mar 17, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 66.08%. Comparing base (1a0cef8) to head (ec55634).
Report is 154 commits behind head on master.

Files with missing lines Patch % Lines
src/lib/replication/repl_dev/raft_repl_dev.h 0.00% 5 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #663      +/-   ##
==========================================
+ Coverage   56.51%   66.08%   +9.57%     
==========================================
  Files         108      109       +1     
  Lines       10300    11338    +1038     
  Branches     1402     1542     +140     
==========================================
+ Hits         5821     7493    +1672     
+ Misses       3894     3115     -779     
- Partials      585      730     +145     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Besroy Besroy closed this Mar 26, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants