Merge branch '8.1.0' into table

eBay · Feb 20, 2025 · 7b6b5dc · 7b6b5dc
2 parents c4dba77 + 26aa104
commit 7b6b5dc
Show file tree

Hide file tree

Showing 4 changed files with 23 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,11 @@
 # @ebay/ui-core-react
 
+## 8.0.4
+
+### Patch Changes
+
+- [#447](https://github.com/eBay/ebayui-core-react/pull/447) [`84b78de`](https://github.com/eBay/ebayui-core-react/commit/84b78de4da25b4b288bc74ab29537a826e479810) Thanks [@montoya332](https://github.com/montoya332)! - fix: top passthrough prop on light box
+
 ## 8.0.3
 
 ### Patch Changes

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@ebay/ui-core-react",
-  "version": "8.0.3",
+  "version": "8.0.4",
   "description": "Skin components build off React",
   "publishConfig": {
     "registry": "https://registry.npmjs.org",

diff --git a/src/ebay-lightbox-dialog/__tests__/index.spec.tsx b/src/ebay-lightbox-dialog/__tests__/index.spec.tsx
@@ -7,14 +7,15 @@ jest.mock('../../common/random-id')
 
 const closeSpy = jest.fn()
 const openSpy = jest.fn()
-const openDialog = () =>
+const openDialog = (props = {}) =>
     render(
         <EbayLightboxDialog
             animated={false}
             open
             onOpen={openSpy}
             onClose={closeSpy}
             a11yCloseText="Close"
+            {...props}
         >
             <EbayDialogHeader>Heading</EbayDialogHeader>
             <p>
@@ -49,4 +50,17 @@ describe('<EbayLightboxDialog>', () => {
         fireEvent.click(document.querySelector(`button.lightbox-dialog__close`))
         expect(closeSpy).toHaveBeenCalled()
     })
+
+    it('should render custom top content', () => {
+        openDialog({
+            top: <div className="custom-top">Top</div>
+        })
+        expect(document.querySelector('.custom-top')).toBeInTheDocument()
+    })
+    it('should render banner image', () => {
+        openDialog({
+            bannerImgSrc:"http://ir.ebaystatic.com/cr/v/c1/skin/image-treatment/mountain.jpeg",
+        })
+        expect(document.querySelector('.lightbox-dialog__image')).toBeInTheDocument()
+    })
 })
diff --git a/src/ebay-lightbox-dialog/lightbox-dialog.tsx b/src/ebay-lightbox-dialog/lightbox-dialog.tsx
@@ -30,7 +30,7 @@ const EbayLightboxDialog: FC<Props> = ({
                 backgroundImage: `url(${bannerImgSrc})`,
                 backgroundPosition: bannerImgPosition
             }} />
-    ) : null
+    ) : rest.top
 
     return (
         <DialogBaseWithState