Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: use target es2015 instead of esnext for better compatibility #443

Merged
merged 2 commits into from
Feb 11, 2025

Conversation

HenriqueLimas
Copy link
Member

nullish coalescing (??) is not supported on Webpack 4, updating the typescript target so it supported accross different builders.

@HenriqueLimas HenriqueLimas added the bug Something isn't working label Feb 11, 2025
@HenriqueLimas HenriqueLimas self-assigned this Feb 11, 2025
Copy link

changeset-bot bot commented Feb 11, 2025

🦋 Changeset detected

Latest commit: be55773

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ebay/ui-core-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@aaron-nance aaron-nance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this is a minor change, aren't all our eBay applications supposed to be on Webpack 5 by now?

Copy link
Contributor

@aaron-nance aaron-nance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we still need this, approved. :-)

@HenriqueLimas HenriqueLimas merged commit fda4f90 into main Feb 11, 2025
7 checks passed
@HenriqueLimas HenriqueLimas deleted the update-ts-target branch February 11, 2025 23:20
@github-actions github-actions bot mentioned this pull request Feb 11, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants