Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: fixed menu active class bug #40

Closed
wants to merge 15 commits into from
Closed

Conversation

Chima1707
Copy link

Fixes HospitalRun/hospitalrun-frontend/HospitalRun#783

Chima1707 and others added 11 commits March 15, 2017 02:38
* add nav Route base data

* Adding defaultRoute to roles

* Setting role in session

* findNavItemByRoute

* adding beforeModel to index route

This addresses the issue that there’s really nothing (presently) on the
homepage.

* modify the set call

* removing logging, moving the transition to the index controller

* remove unneeded spaces

* Adding acceptance test

* cleanup per @jkleinsc instructions

Removed commented out code, using isEmpty, removing unused import

* cleanup per @jkleinsc

Using isEqual and cleaning up the formatting of the looping structure.

* remove session.set

Not needed. Thx for the feedback @jkleinsc

* removing the edge case for users admins

* User Admins get the blank welcome screen

* working to get the users test to function properly.

* correcting a conflict in the branch

* Fixed failing test

Moved user administrator role test to users-test because it needs the
fake rest calls defined there.
* added basic translations for report

* feat: added report model

* feat: added report tabs to visit page

* feat: added report route to router

* feat: added report page

* feat: reports to visits children

* feat: added add/delete report capabilities

* fix: fixed diagnosisContainer issue on browser back history button

* fix: display different report title based on type of visit

* Modified Package.json for new NPM Deployment

* fix: added next appointment and operative plans to opd form

* Restore package.json to working state

* Implement custom forms for OPD Report

* Add custom forms attribute to report model

* fix: saved report object

* fix: added preview report feat

* fix: added report by visit view

* fix: added logic to show different report sections

* fix: added some report translations

* fix: edited report model

* fix: implemented logic to toggle between show report and new report

* Remove preview functionality from OPD Reports

* Implement print button

* Remove print section header

* Write styles and markup for print page

* Refactor report header into partial

* Rename report types

* fix style lint errors

* fix: completed internationalization and lint fix

* 0.9.18

* Incremented version number, added scope

* fix: remove patientId field, fixed next appointment bug, removed unused translation

* fix: change date fields to simple text

* fix: fixed bug that has to do with page header title

* Added .travis.yml file for building and deploying to npm

* Removed ember test. Pretty much does the same as npm test

* Allowing all branches to be tested and built

* fix: added translations for discharge report

* fix: modified report model to accommodate discharge report

* fix: added discharge report

* fix: added next appointment date to discharge report on save

* fix: implemented next appointment as a mixin

* fix: added translations for followup appointment message

* fix: made sure a followup appointment exists before you generate discharge report

* Add Hospital Info report header as option config

* Add report model to patient-diagnosis and visit unit tests

* fix: fixed report header conflict

* Refactor report template

* Add custom forms to discharge report

* fix: added hospital info doc to environment

* fix: create sample docs on couchdb

* Change how "new" routes work

Makes sure that if user redirects to url the patient is properly
selected.

* fix: made sure sample docs are created when deleted

* Add query parameters to improve app navigation experience

* set patient on visit models

* Redirect reports/new to patients when no visit model

* Clean up visit controller

* Set visit on models

* Update visit acceptance tests

* Fix appointments new surgery test error

* Remove double reference to visits controller

* Display visit diagnosis appropriately

* Fix Operative Plans display

* fix: fixed translation lables for next appointments

* fix: modified get futureAppointment to work for list of appointments

* fix: implemented next appointments on both template and controller

* fix: fix lint

* FIx next appointments display

* Added auto trigger hospitalrun-server refresh script on successful build

* Fix reports controller bug

* Add diagnosis container

* Set patient on model if model is not new

* Set visit on controller and add display current operative plan

* Add `Completed By` field to report

* Refactor reports template

* Ensure reports.edit returns to visits.edit

* Display patient procedures on report

* Remove discharge report compulsory next appointment modal

* Fix `completed by` on report page

* Style select element properly; Add titles to report

* fix: fix  new user title bug after a new user has been added

* Added deploy branches to .travis.yml

* fix: fix  test for new user title bug

* fix: updated report template with testing attributes on fields

* fix: update visit template with testing attributes on fields

* fix: implemented acceptance tests for opd and discharge reports

* Implement acceptance tests for OPD Report

* Refactor code to conform with style guide

* Fix nextAppointment bug
This information can now be set by the print header admin option.
Updated to use abstract _handleError function.
* Add ember-concurrency addon version 0.7.19

* Refactor admin/address/route to use e-c

This is the example I used in issue HospitalRun#969. It is illustrates how to use
ember-concurrency tasks in routes.

* Refactor patients/delete/controller to use e-c

Example of using ember-concurrency tasks to manage a complex promise
chain of events. I picked this one mainly because I wanted to illustrate
the simplicity of using e-c tasks to manage what was otherwise a very
complex promise chain.

I tried to preserve some of the concurrency described in the previous
promise based code. However, after some analysis and discussion on the
Ember Slack channels difference between preserving the concurrency and
just running the resolutions serially are likely very small. In this
case the use of `all()` could likely be removed without a significant
impact on performance. I mention this later optimisation as a way to
make the code even easier to grok. I'll leave the debate to further
discussion.
@Chima1707 Chima1707 closed this Mar 20, 2017
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants