[21053] Move DR TypeConsistencyEnforcement & DataRepresentation from TypeConsistency to DataReaderQos #779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
…entationQosPolicy to correct place Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
JesusPoderoso
force-pushed
the
feature/21053
branch
from
aa1b881 to
127a61c
Compare
Mario-DL
requested changes
May 22, 2024
There was a problem hiding this comment.
We would need to change the references to eprosima::fastdds::dds::TypeConsistencyQos to eprosima::fastdds::dds::TypeConsistencyEnforcementQos, for instance, in the docs/fastdds/api_reference/dds_pim/subscriber/typeconsistencyqos.rst.
Also in the DDSCodeTester there are some declarations consistency_qos.representation that should be changed to representation()
JesusPoderoso
changed the title
JesusPoderoso
force-pushed
the
feature/21053
branch
4 times, most recently
from
68003e0 to
84c1e90
Compare
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
JesusPoderoso
force-pushed
the
feature/21053
branch
from
84c1e90 to
8967dc8
Compare
|
@richiprosima please test_3 this |
JesusPoderoso
added
ready-to-merge
needs-review
and removed
ci-pending
ready-to-merge
labels
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates and improves the documentation of TypeConsistency and DataRepresentation QoS policies
Contributor Checklist
Reviewer Checklist