-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[20953] Support Type-Lookup Service with new new GUID-less Discovery Server #4768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
105294a
to
a9dfd62
Compare
24fa3fe
to
68476c3
Compare
a9dfd62
to
904b75b
Compare
68476c3
to
3774d59
Compare
904b75b
to
31ff9c1
Compare
3774d59
to
a25d707
Compare
01b4fad
to
1113cea
Compare
758babf
to
b6c63bf
Compare
09e9f9a
to
688cd0f
Compare
a25d707
to
7ec4d31
Compare
7ec4d31
to
007fae9
Compare
rsanchez15
previously approved these changes
Jul 24, 2024
621fb7e
to
af21057
Compare
…UID instead of proxy_data Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
af21057
to
62a8f0e
Compare
rsanchez15
approved these changes
Jul 26, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR modifies the behavior of TypeLookup service to ensure compatibility with the Discovery Server. Participants now issue the TypeLookupRequest to the participant that sent them the Data (r|w), rather than to the participant containing the endpoint. This adjustment allows servers to respond to their clients, thereby keeping discovery traffic limited to servers. Additionally, it addresses minor changes to improve functionality with the Discovery Server.
Contributor Checklist
versions.md
file (if applicable).Reviewer Checklist