Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[20991] Fix sanitizers CI test summary report #4815

Merged
merged 1 commit into from
May 24, 2024
Merged

[20991] Fix sanitizers CI test summary report #4815

merged 1 commit into from
May 24, 2024

Conversation

Mario-DL
Copy link
Member

@Mario-DL Mario-DL commented May 21, 2024 •
edited by JesusPoderoso
Loading

Signed-off-by: Mario Dominguez mariodominguez@eprosima.com

Description

This PR adds a workaround the prevent reading errors when generating sanitizer reports either because of unexpected characters or early-finishing files. It decodes information as utf-8 and replaces any strange character with a mark (?) given the case.

@Mergifyio backport 2.14.x 2.13.x 2.10.x 2.6.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • NO Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • NO Any new/modified methods have been properly documented using Doxygen.
  • NO Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • NO Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • NO Changes are API compatible.
  • NO New feature has been added to the versions.md file (if applicable).
  • NO New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@Mario-DL
Refs #20991: Process reading file errors as 'replace'
a068526 
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
@Mario-DL Mario-DL added this to the v3.0.0 milestone May 21, 2024
@Mario-DL Mario-DL requested a review from richiprosima May 21, 2024 05:53
@github-actions github-actions bot added the ci-pending PR which CI is running label May 21, 2024
JesusPoderoso
JesusPoderoso approved these changes May 21, 2024
View reviewed changes
Copy link
Contributor

@JesusPoderoso JesusPoderoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It worked! 🎉 🎉
LGTM

@JesusPoderoso JesusPoderoso added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels May 21, 2024
@EduPonz
Copy link

EduPonz commented May 24, 2024

@Mergifyio backport 2.14.x 2.13.x 2.10.x 2.6.x

@EduPonz EduPonz merged commit 7316d35 into master May 24, 2024
9 of 12 checks passed
@EduPonz EduPonz deleted the fix/20991 branch May 24, 2024 06:35
@mergify Mergify
Copy link
Contributor

mergify bot commented May 24, 2024 •
edited
Loading

backport 2.14.x 2.13.x 2.10.x 2.6.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request May 24, 2024
@Mario-DL @mergify
Fix sanitizers CI test summary report (#4815)
acc98dc 
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
(cherry picked from commit 7316d35)
mergify bot pushed a commit that referenced this pull request May 24, 2024
@Mario-DL @mergify
Fix sanitizers CI test summary report (#4815)
cf55b57 
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
(cherry picked from commit 7316d35)
This was referenced May 24, 2024
Merged
Merged
mergify bot pushed a commit that referenced this pull request May 24, 2024
@Mario-DL @mergify
Fix sanitizers CI test summary report (#4815)
0b0fc36 
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
(cherry picked from commit 7316d35)
mergify bot pushed a commit that referenced this pull request May 24, 2024
@Mario-DL @mergify
Fix sanitizers CI test summary report (#4815)
8e0a810 
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
(cherry picked from commit 7316d35)
This was referenced May 24, 2024
Merged
Merged
MiguelCompany pushed a commit that referenced this pull request May 25, 2024
@mergify @Mario-DL
Fix sanitizers CI test summary report (#4815) (#4840)
0ceb62c 
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
(cherry picked from commit 7316d35)

Co-authored-by: Mario Domínguez López <116071334+Mario-DL@users.noreply.github.com>
EduPonz pushed a commit that referenced this pull request May 27, 2024
@mergify @Mario-DL
Fix sanitizers CI test summary report (#4815) (#4838)
430dcad 
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
(cherry picked from commit 7316d35)

Co-authored-by: Mario Domínguez López <116071334+Mario-DL@users.noreply.github.com>
EduPonz pushed a commit that referenced this pull request May 27, 2024
@mergify @Mario-DL
Fix sanitizers CI test summary report (#4815) (#4839)
30375b0 
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
(cherry picked from commit 7316d35)

Co-authored-by: Mario Domínguez López <116071334+Mario-DL@users.noreply.github.com>
EduPonz pushed a commit that referenced this pull request May 28, 2024
@mergify @Mario-DL
Fix sanitizers CI test summary report (#4815) (#4841)
9899ca6 
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
(cherry picked from commit 7316d35)

Co-authored-by: Mario Domínguez López <116071334+Mario-DL@users.noreply.github.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@JesusPoderoso JesusPoderoso JesusPoderoso approved these changes

@richiprosima richiprosima Awaiting requested review from richiprosima

Assignees
No one assigned
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Mario-DL @EduPonz @JesusPoderoso