Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[21077] Update Fast DDS docs QoS examples #4842

Merged
merged 6 commits into from
Jun 20, 2024
Merged

[21077] Update Fast DDS docs QoS examples #4842

merged 6 commits into from
Jun 20, 2024

Conversation

cferreiragonz
Copy link
Contributor

@cferreiragonz cferreiragonz commented May 24, 2024

Description

This PR reviews that the API of QoS is identical for all entities that share a common QoS. It also makes the PropertyPolicyQoS of DataWriters and DataReader unmutable (such as the one of Participants), until a deeper study is made on what Policies should be mutable on enabled entities.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • ❌ Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • ❌ Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@cferreiragonz cferreiragonz added this to the v3.0.0 milestone May 24, 2024
@cferreiragonz cferreiragonz added the needs-review PR that is ready to be reviewed label May 24, 2024
@github-actions github-actions bot added the ci-pending PR which CI is running label Jun 13, 2024
@cferreiragonz cferreiragonz requested review from MiguelCompany and removed request for MiguelCompany June 14, 2024 06:28
@cferreiragonz cferreiragonz force-pushed the qos_api_review branch 2 times, most recently from 1b69764 to b603f6c Compare June 18, 2024 12:34
@Tempate Tempate self-requested a review June 18, 2024 13:43
Copy link
Contributor

@Tempate Tempate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
@cferreiragonz cferreiragonz changed the title [21077] Review Fast DDS docs QoS examples [21077] Update Fast DDS docs QoS examples Jun 19, 2024
@cferreiragonz cferreiragonz requested a review from Tempate June 19, 2024 07:02
@cferreiragonz cferreiragonz removed the needs-review PR that is ready to be reviewed label Jun 19, 2024
Copy link
Contributor

@Tempate Tempate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EduPonz EduPonz merged commit 38d4765 into master Jun 20, 2024
16 of 17 checks passed
@EduPonz EduPonz deleted the qos_api_review branch June 20, 2024 06:21
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
ci-pending PR which CI is running
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants