-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[21321] Move Time_t
to dds
namespace and some *Attributes to xmlparser
#5065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Time_t
to dds
namespace and some *Attributes to xmlaparser
Time_t
to dds
namespace and some *Attributes to xmlparser
7 tasks
d542b54
to
3682409
Compare
This was referenced Jul 15, 2024
…:fastdds::xmlparser namespace Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
… eprosima::fastdds::dds::Time_t Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
JesusPoderoso
suggested changes
Jul 23, 2024
test/mock/rtps/RTPSParticipantAttributes/fastdds/rtps/attributes/RTPSParticipantAttributes.hpp
Outdated
Show resolved
Hide resolved
test/mock/rtps/RTPSParticipantAttributes/fastdds/rtps/attributes/RTPSParticipantAttributes.hpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
JesusPoderoso
suggested changes
Jul 23, 2024
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
JesusPoderoso
approved these changes
Jul 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
(check CI of this commit, commits since then have not changed building code)
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR:
eprosima::fastdds::xmlparser
namespaceTime_hpp
indds::Time_t
andrtps::Time_t
Contributor Checklist
versions.md
file (if applicable).Time_t
todds
namespace and some *Attributes toxmlparser
docs Fast-DDS-docs#870Time_t.i
indds::Time_t
andrtps::Time_t
Fast-DDS-python#164Time_t
andDuration_t
ShapesDemo#165Reviewer Checklist