[21564] [21666] Change xsd files installation directory to share/fastdds and remove icons on windows uninstall
#5140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
rsanchez15
changed the title
xsd files installation directory to share/fastddsxsd files installation directory to share/fastdds
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Mario-DL
force-pushed
the
bugfix/xsd-installdir
branch
from
93bff05 to
89fe096
Compare
Mario-DL
changed the title
xsd files installation directory to share/fastddsxsd files installation directory to share/fastdds and remove icons on windows uninstall
This reverts commit ac18b8a.
Mario-DL
requested review from
richiprosima
and removed request for
richiprosima
JesusPoderoso
approved these changes
Oct 3, 2024
JesusPoderoso
added
ready-to-merge
|
@Mergifyio backport 3.0.x |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Oct 3, 2024
…ve icons on windows uninstall (#5140) * Refs #21366: Change xsd installation directory to .../share/fastdds Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * TMP commit for testing Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #21564: Remove redundant installation of xsd file again Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #21564: Change expected xsd installation path Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Revert "TMP commit for testing" This reverts commit ac18b8a. --------- Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> (cherry picked from commit 6bb7e9a)
8 tasks
MiguelCompany
pushed a commit
that referenced
this pull request
Oct 7, 2024
…ve icons on windows uninstall (#5140) (#5302) * Refs #21366: Change xsd installation directory to .../share/fastdds Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * TMP commit for testing Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #21564: Remove redundant installation of xsd file again Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #21564: Change expected xsd installation path Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Revert "TMP commit for testing" This reverts commit ac18b8a. --------- Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> (cherry picked from commit 6bb7e9a) Co-authored-by: Mario Domínguez López <116071334+Mario-DL@users.noreply.github.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This other PR:
fastdds_profiles.xsdandfastdds_static_discovery.xsdinstallation directory to.../share/fastdds(previously in.../share) .fastdds_profiles.xsdwithin the/toolsCMakeLists.txt.IMPORTANT this PR must be merged along with:
https://gitlab.intranet.eprosima.com/eProsima/fastdds-installers/-/merge_requests/20. In turn, this MR has to be backported to
3.0.xbranchThis MR:
fastdds x.x.xinstallation directory.*.xsdfiles into(install_prefix)\share\fastdds[21564] Update
fastdds_profiles.xsdfile location Fast-DDS-docs#925@Mergifyio backport 3.0.x
Contributor Checklist
versions.mdfile (if applicable).Reviewer Checklist