-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[22463] Fix Discovery CLI Tool in Windows (No privileges) (backport #5493) #5510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cherry-pick of 2cdc2d9 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
12 tasks
3345885
to
9a4ca86
Compare
@Mergifyio rebase |
* Refs #22463: Add test to check proper link between python and cpp files Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #22463: Remove .bat.in and call .exe from python Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #22463: Apply suggestions Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> --------- Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> (cherry picked from commit 2cdc2d9) # Conflicts: # tools/fastdds/discovery/parser.py
Signed-off-by: Javier Gil Aviles <javiergil@eprosima.com>
✅ Branch has been successfully rebased |
9a4ca86
to
7d9b19f
Compare
Javgilavi
approved these changes
Feb 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with green CI
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When Fast DDS is compiled without admin privileges, no symlink is created to link to the
fast-discovery-server-1.0.1.exe
file. In this case, an alternative.bat
is created to call the tool. However, the.bat
file contains an error and fails to properly call the tool because it adds an unknown parameter as argument. To solve this, the.bat
file was removed and the.exe
file is called from the Python script directly. This gives more control over the tool as it does not bypass the Python script when compiling without admin privileges.@Mergifyio backport 3.1.x 3.0.x
Contributor Checklist
Commit messages follow the project guidelines.
The code follows the style guidelines of this project.
Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
N/A Any new/modified methods have been properly documented using Doxygen.
N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
Changes are backport compatible: they do NOT break ABI nor change library core behavior.
Changes are API compatible.
N/A New feature has been added to the
versions.md
file (if applicable).N/A New feature has been documented/Current behavior is correctly described in the documentation.
Applicable backports have been included in the description.
Reviewer Checklist
This is an automatic backport of pull request #5493 done by [Mergify](https://mergify.com).