Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Log any errors before cancel_init() (backport #5530) #5545

Merged
merged 2 commits into from
Jan 20, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jan 8, 2025

This PR improves the debugging process by adding a proper logging right before running SecurityManager::cancel_init() in this catch block

Description

More details in this ticket #5531

@Mergifyio backport 3.1.x 3.0.x 2.14.x 2.10.x

Fixes #(issue)

Contributor Checklist

  • Commit messages follow the project guidelines.

  • The code follows the style guidelines of this project.

  • NA Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally

  • NA Any new/modified methods have been properly documented using Doxygen.

  • NA Any new configuration API has an equivalent XML API (with the corresponding XSD extension)

  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.

  • Changes are API compatible.

  • NA New feature has been added to the versions.md file (if applicable).

  • NA New feature has been documented/Current behavior is correctly described in the documentation.

  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • NA Check CI results: failing tests are unrelated with the changes.

This is an automatic backport of pull request #5530 done by [Mergify](https://mergify.com).

* Log any errors before cancel_init()

Signed-off-by: Santti4go <santiaupi@gmail.com>

* Code style

Signed-off-by: Santti4go <santiaupi@gmail.com>

* Apply suggestion

Signed-off-by: Santti4go <santiaupi@gmail.com>

---------

Signed-off-by: Santti4go <santiaupi@gmail.com>
(cherry picked from commit 165d64e)
* Regression tests

Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com>

* Update log macro

Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com>

* Uncrustify

Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com>

* Fix CI log flush

Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com>

---------

Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com>
@EugenioCollado
Copy link
Contributor

Backported commit 25b117fcf

@EugenioCollado EugenioCollado added this to the v3.0.2 milestone Jan 13, 2025
@Mario-DL Mario-DL requested review from Mario-DL and removed request for Mario-DL January 14, 2025 08:12
@github-actions github-actions bot added the ci-pending PR which CI is running label Jan 14, 2025
@Mario-DL Mario-DL merged commit 415ac9b into 3.0.x Jan 20, 2025
17 checks passed
@Mario-DL Mario-DL deleted the mergify/bp/3.0.x/pr-5530 branch January 20, 2025 15:54
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
ci-pending PR which CI is running
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants