Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[WIP] attempt to make sure streams are closed #5552

Draft
wants to merge 1 commit into
base: develop-6.x.x
Choose a base branch
from

Conversation

line-o
Copy link
Member

@line-o line-o commented Nov 14, 2024

Description:

This is work in progress as we have still a test failure in BinaryValueFromBinaryStringTest.cast_hexBinary_to_base64

Reference:

fixes #5345

Type of tests:

none added

@line-o line-o marked this pull request as draft November 14, 2024 13:21
@adamretter
Copy link
Contributor

adamretter commented Nov 14, 2024

@line-o Just to warn you that this approach won't work, you need to first better understand the lifetime of how these streams are designed to be used.

@reinhapa
Copy link
Member

@line-o Just to warn you that this approach won't work, you need to first better understand the lifetime of how these streams are designed to be used.

@adamretter I was tinkering with @line-o a bit on that specific part of the code without better knowledge (as the draft state also hopefully refelcts 😎)

Any insights and tips to approach the problems are welcome of course

@adamretter
Copy link
Contributor

adamretter commented Nov 14, 2024

@reinhapa Sure, I did see the draft status. I just wanted to (a) help you guys not waste your time by heading in the wrong direction, and (b) not cause stability issues in other aspects of eXist-db by you heading in the wrong direction.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants