Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Softlock after dragon fight #30

Closed
eadmaster opened this issue Nov 3, 2024 · 4 comments
Closed

Softlock after dragon fight #30

eadmaster opened this issue Nov 3, 2024 · 4 comments
Labels
bug Something isn't working high-priority

Comments

@eadmaster
Copy link
Owner

eadmaster commented Nov 3, 2024

Reported by multiple sources the game is soft-locking at this position in the event:
https://github.com/eadmaster/pcrown/blob/master/script/eng/events/015_00_1.TXT#L6

Princess_Crown_Japan_1M_English-241102-174319 Princess_Crown_Japan_1M_English-241102-174410

Need to add a translation and check the game running in the yabause debugger.

Test savegame: retroarch_saves.zip

(there may be other cases like this still to be found)

Current workaround: temporarily switch back to the Japanese untranslated game to pass this point.

@eadmaster eadmaster added bug Something isn't working high-priority help wanted Extra attention is needed and removed high-priority labels Nov 3, 2024
@eadmaster
Copy link
Owner Author

eadmaster commented Nov 6, 2024

converted yabause save:
backup.zip

(savestates were made with yabause 0.9.14)

to reproduce: load the 1st save, exit the inn and keep walking to the left.

Use these cheats to quickly pass the fights:
princess crown yabause cheats.yct.zip

@eadmaster
Copy link
Owner Author

eadmaster commented Nov 8, 2024

After some experimenting, this seems a bug with the eventeditor.

TODO: compare byte structures in 015_00_1.EVN vs 015_00_1.EVN.eng at offset 0x1B20. There must be something in 015_00_1.EVN that 015_00_1.EVN.eng is missing...

Possible temp. fix for the next release: restore the original jap .evn file to pass that point (all the dialogs in that scene will go back to Japanese)

@eadmaster
Copy link
Owner Author

eadmaster commented Nov 29, 2024

update: added a better fix (reduced English text instead of Jap dialogues)

found a possible cause:

  • Unknown command A8 at offset 00001613 -> need to guess the correct cmd lenght?
  • or, maybe some prev commands were not parsed correctly, since there is no explicit separator for them:
--- command parsed:
name: CMD29
value: 0000A0
offset: 15FD

--- command parsed:
name: StartLoop
value: 
offset: 1603

--- command parsed:
name: CMD7D
value: 00FF
offset: 1606

--- command parsed:
name: Jump
value: 01300188
offset: 160B

i see a CE byte at offset 0x1609 which is skipped by the parser (very suspicious)

eadmaster added a commit that referenced this issue Dec 1, 2024
@eadmaster
Copy link
Owner Author

superseded by #91

@eadmaster eadmaster changed the title Fix softlock after dragon fight Softlock after dragon fight Dec 6, 2024
@eadmaster eadmaster removed the help wanted Extra attention is needed label Jan 20, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working high-priority
Projects
None yet
Development

No branches or pull requests

1 participant