Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Redo ESP32 partitions.csv parsing #62

Merged
merged 1 commit into from
Nov 3, 2024
Merged

Redo ESP32 partitions.csv parsing #62

merged 1 commit into from
Nov 3, 2024

Conversation

earlephilhower
Copy link
Owner

Support comments ('#'), -K and -M modifiers, don't skip 1st line,
and match on the "type" and note "name" fields. Match "LittleFS"
type, too.

Fixes #61

@earlephilhower
Copy link
Owner Author

earlephilhower commented Nov 2, 2024

(edit) - Updated version in "test2.zip" to ensure IDE doesn't cache old rev)
test2.zip

@stef-ladefense, please exit the IDE, manually remove your current VSIX, and try the one attached in the ZIP file here. It parses the CSV you attached to the bug, or at least appears to do so for me.

If you could report back that would be appreciated as I'm not a ESP32 user...

Support comments ('#'), -K and -M modifiers, don't skip 1st line,
and match on the "type" and note "name" fields.   Match "LittleFS"
type, too.

Fixes #61
@stef-ladefense
Copy link

(edit) - Updated version in "test2.zip" to ensure IDE doesn't cache old rev) test2.zip

@stef-ladefense, please exit the IDE, manually remove your current VSIX, and try the one attached in the ZIP file here. It parses the CSV you attached to the bug, or at least appears to do so for me.

If you could report back that would be appreciated as I'm not a ESP32 user...

hi @earlephilhower you are fast ! 👍🏻

the 1.3.0 version work with my worse example csv ;)

LittleFS Filesystem Uploader v1.3.0 -- https://github.com/earlephilhower/arduino-littlefs-upload

Sketch Path: D:\Arduino\ESP32_RadioWeb\ESP32S3_RadioWeb_0_66
Data Path: D:\Arduino\ESP32_RadioWeb\ESP32S3_RadioWeb_0_66\data
Device: ESP32 series, model esp32s3
Using partition: partitions.csv in sketch folder
Partitions: D:\Arduino\ESP32_RadioWeb\ESP32S3_RadioWeb_0_66\partitions.csv
Start: 0x610000
End: 0x9f0000

Building LittleFS filesystem
Command Line: C:\Users\Stephane\AppData\Local\Arduino15\packages\esp32\tools\mklittlefs\3.0.0-gnu12-dc7f933\mklittlefs.exe -c D:\Arduino\ESP32_RadioWeb\ESP32S3_RadioWeb_0_66\data -p 256 -b 4096 -s 4063232 C:\Users\Stephane\AppData\Local\Temp\tmp-6364-53B1Z1RPXuOM-.littlefs.bin

Uploading LittleFS filesystem
Command Line: C:\Users\Stephane\AppData\Local\Arduino15\packages\esp32\tools\esptool_py\4.6\esptool.exe --chip esp32s3 --port COM8 --baud 921600 --before default_reset --after hard_reset write_flash -z --flash_mode dio --flash_freq 80m --flash_size detect 6356992 C:\Users\Stephane\AppData\Local\Temp\tmp-6364-53B1Z1RPXuOM-.littlefs.bin

Wrote 4063232 bytes (886280 compressed) at 0x00610000 in 28.2 seconds (effective 1152.6 kbit/s)...
Hash of data verified.

Leaving...
Hard resetting via RTS pin...

Completed upload.

👍🏻 👍🏻 👍🏻 👍🏻

you are the best!

@earlephilhower earlephilhower merged commit 71a20b8 into main Nov 3, 2024
@earlephilhower earlephilhower deleted the fancypants branch November 3, 2024 00:18
@stef-ladefense
Copy link

just a detail

Partitions: D:\Arduino\ESP32_RadioWeb\ESP32S3_RadioWeb_0_66\partitions.csv
Start: 0x610000
End: 0x9f0000

0x9f0000 is not end but length
end is 0x610000+0x9f0000=0x1000000
last adress is 0xffffff (start 0 -> 0x1000000-1 for 16Mb)

@earlephilhower
Copy link
Owner Author

Argh, thought your message was that it was working and this just missed the release.

Is the generated FS proper or busted? I think it's broken and not the right size because the old code actually added fsStart to fsEnd before doing it's magic.

@earlephilhower
Copy link
Owner Author

#63 to fix

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

have error with custom csv
2 participants