Expand documentation to clarify pin notation and Servo usage #2326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AIWintermuteAI
changed the title
AIWintermuteAI
changed the title
earlephilhower
requested changes
Aug 8, 2024
|
Ooops. Sorry, got too busy with my main work recently. I can still address the comments and get the PR ready, if you want. |
|
Sure, if you're up for it! |
earlephilhower
approved these changes
Aug 31, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is not explained anywhere that unlike official Arduino mbed cores, you need to prepend D before number for digital pins.
Another rather large difference is that servo PWM ranges are set very conservatively according to #776.
I think this can be two common gotchas for people trying to port their code from Arduino mbed nano core, so perhaps worth adding them to the docs.