early out of (un)maskInterrupts() if no GPIO interrupts need to be masked #2831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My application is designed to generate HSTX data on core0 in interrupts, but also uses hardware SPI for SD card access. It turns out that the amount of time spent in maskInterrupts/ unmaskInterrupts, even with an empty _usingIRQs, is too long. Add a quick check and avoid touching the interrupt disable flag if there's not actually any GPIO interrupt to (un)mask.
There was a problem hiding this comment.
Wow, that's tight timing. I wonder if the STL is doing actual memory allocations/etc. in the for (auto x: y) iteration even with an empty list...
You'll need to adjust formatting using tools/restyle.sh or just manually indent/format the new short-circuit path to get through CI.
-edit- update formatting -edit-
if (_usingIRQs.empty()) {
return;
}
OTW, LGTM!
|
Thanks, I've tried to update the branch with the correct style. |
jepler
force-pushed
the
spi-maskinterrupts-earlyout
branch
from
e95fac5 to
66d8fa1
Compare
earlephilhower
approved these changes
Feb 28, 2025
|
thank you |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My application is designed to generate HSTX data on core0 in interrupts, but also uses hardware SPI for SD card access.
It turns out that the amount of time spent in
maskInterrupts/unmaskInterruptswith interrupts disabled, even with an empty_usingIRQs, is too long.Add a quick check and avoid touching the interrupt disable flag if there's not actually any GPIO interrupt to (un)mask.
@ladyada this fixes the hstx video glitches during SPI SD card access