Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Partial payloads, ingestion fixes and performance improvements #21

Merged
merged 4 commits into from
Jun 5, 2024

Conversation

sgwilym
Copy link
Contributor

@sgwilym sgwilym commented Jun 5, 2024

  • Store.ingestPayload now has a allowPartial param which, when enabled, permits the ingestion of payloads smaller than the entry's stated length. No verification is performed. Defaults to false.
  • Payload ingestion during sync now only begins when some bytes have been received via DataSendPayload, instead of as soon as we get DataReplyPayload.
  • Fixed a bug where mismatching ingested data would not be deleted after being detected.
  • Fixed a bug where partially received payloads were retrieved from the store as though they were complete.

sgwilym added 4 commits June 5, 2024 11:08
BREAKING: Added allowPartial param to Store.ingestPayload
feat: Store.ingestPayload now accepts partial payloads
fix: Store.ingestPayload does not no_op if the payload already has a partial
fix: Store.ingestPayload now rejects (deletes) mismatched payloads after detecting them.
@sgwilym sgwilym merged commit cf96cf5 into main Jun 5, 2024
1 check passed
@sgwilym sgwilym deleted the payload-fixes branch June 5, 2024 12:16
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant