Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

WGPS: Add ReadyTransport and friends #57

Merged
merged 5 commits into from
Nov 5, 2024
Merged

WGPS: Add ReadyTransport and friends #57

merged 5 commits into from
Nov 5, 2024

Conversation

sgwilym
Copy link
Contributor

@sgwilym sgwilym commented Oct 25, 2024

A small function for intercepting the first few bytes of a WGPS session in order to return the session's maximum payload size, received commitment, and transport set to immediately start returning encoded WGPS messages.

@sgwilym sgwilym added the enhancement New feature or request label Oct 25, 2024
@sgwilym sgwilym requested a review from AljoschaMeyer October 25, 2024 13:04
Copy link
Contributor

@AljoschaMeyer AljoschaMeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only some small stylistic nitpicks.

wgps/src/ready_transport.rs Show resolved Hide resolved
wgps/src/ready_transport.rs Outdated Show resolved Hide resolved
wgps/src/ready_transport.rs Outdated Show resolved Hide resolved
wgps/src/ready_transport.rs Outdated Show resolved Hide resolved
@sgwilym sgwilym requested a review from AljoschaMeyer November 5, 2024 10:25
@sgwilym sgwilym merged commit 690ea4e into main Nov 5, 2024
14 checks passed
@sgwilym sgwilym deleted the commitment-reveal branch November 5, 2024 13:10
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

2 participants