Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Templates not found when unclosed HMTL elements present? #53

Closed
nettrom opened this issue Nov 11, 2013 · 1 comment
Closed

Templates not found when unclosed HMTL elements present? #53

nettrom opened this issue Nov 11, 2013 · 1 comment

Comments

@nettrom
Copy link

nettrom commented Nov 11, 2013

Parsing and filtering templates on this revision leads to none found: https://en.wikipedia.org/w/index.php?title=User:Today%27s_Xtra&oldid=581237766

If I edit the source so all the font elements have matching close tags, the templates are found correctly.

Given the mix of HTML and wikitext, I'm not sure whether this actually should find any templates. In that case perhaps still interesting as a testcase?

@ghost ghost assigned earwig Nov 12, 2013
@earwig
Copy link
Owner

earwig commented Nov 12, 2013

It should be finding them, yes. This is a side effect of a certain limitation of the parser that's I've already filed (#42), so it'll go away when I fix that.

@earwig earwig closed this as completed Nov 12, 2013
@earwig earwig modified the milestone: version 0.4 May 25, 2014
@earwig earwig removed their assignment Dec 30, 2016
earwig added a commit that referenced this issue Jun 23, 2017
Also removed the max cycles stop-gap, allowing much more complex pages
to be parsed quickly without losing nodes at the end

Also fixes #65, fixes #102, fixes #165, fixes #183
Also fixes #81 (Rafael Nadal parsing bug)
Also fixes #53, fixes #58, fixes #88, fixes #152 (duplicate issues)
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

2 participants