fix enhance_sanity_check for PythonPackage
#3477
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When trying to add, not replace paths/commands for the sanity check of Python packages the default `lib/python/%(pyshortver)s/site-packages` gets replaced. This leads to duplicating this in many easyconfigs. Use the `custom_paths` argument for that but still honor if that is given from a child class.
boegel
requested changes
Dec 11, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to add, not replace paths/commands for the sanity check of Python packages the default
lib/python/%(pyshortver)s/site-packagesgets replaced.This leads to duplicating this in many easyconfigs. Use the
custom_pathsargument for that but still honor if that is given from a child class.custom_paths&custom_commandssanity-check arguments easybuild-framework#4679