Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

remove use of deprecated parse_log_for_error in RPackage easyblock #3515

Merged
merged 4 commits into from
Dec 21, 2024

Conversation

branfosj
Copy link
Member

(created using eb --new-pr)

boegel
boegel previously requested changes Dec 3, 2024
easybuild/easyblocks/generic/rpackage.py Outdated Show resolved Hide resolved
@boegel boegel changed the title remove use of deprecated parse_log_for_error in rpackage remove use of deprecated parse_log_for_error in RPackage easyblock` Dec 3, 2024
@boegel boegel changed the title remove use of deprecated parse_log_for_error in RPackage easyblock` remove use of deprecated parse_log_for_error in RPackage easyblock Dec 3, 2024
@branfosj
Copy link
Member Author

There are test reports using this in easybuilders/easybuild-easyconfigs#21908

Copy link
Contributor

@lexming lexming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lexming
Copy link
Contributor

lexming commented Dec 21, 2024

Merging, thanks @branfosj

@lexming lexming dismissed boegel’s stale review December 21, 2024 11:47

Review addressed by author

@lexming lexming merged commit 6ea38b6 into easybuilders:5.0.x Dec 21, 2024
19 checks passed
@branfosj branfosj deleted the 20241123163528_new_pr_rpackage branch December 21, 2024 11:48
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants