Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Trim the code when importing a profile #1194

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

imatrisciano
Copy link
Contributor

When sharing a profile code with friends sometimes extra spaces are copied alongside the id. If that's the case a 404 error will be generated. This commit adds a trim() to the code to remove any whitespaces.

When sharing a profile code with friends sometimes extra spaces are copied alongside the id. If that's the case a 404 error will be generated. This commit adds a trim() to the code to remove any whitespaces.
@CLAassistant
Copy link

CLAassistant commented Jan 31, 2024

CLA assistant check
All committers have signed the CLA.

@NicholasHallman
Copy link

NicholasHallman commented Feb 11, 2024

I was just about to fork the code to add this hehe

Copy link
Collaborator

@MythicManiac MythicManiac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, this is something I keep forgetting to fix but definitely has been a problem

@MythicManiac MythicManiac changed the base branch from master to develop February 15, 2024 03:48
@MythicManiac MythicManiac merged commit a1d7120 into ebkr:develop Feb 15, 2024
3 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants