PC Game Pass support #856
PC Game Pass support #856
Conversation
src/providers/generic/game/directory_resolver/win/XGPDirectoryResolver.ts
Outdated
Show resolved
Hide resolved
src/model/game/StorePlatform.ts
Outdated
| @@ -4,5 +4,6 @@ export enum StorePlatform { | |||
| EPIC_GAMES_STORE = "Epic Games Store", | |||
| OCULUS_STORE = "Oculus Store", | |||
| ORIGIN = "Origin / EA Desktop", | |||
| PC_GAME_PASS = "PC Game Pass", | |||
There was a problem hiding this comment.
PC_GAME_PASS should be XBOX_GAME_PASS
There was a problem hiding this comment.
Feels like Xbox Game Pass is still a more recognizable name for players.
I wonder if this option can work for Windows store too.
| @@ -79,6 +80,13 @@ const RUNNERS: RunnerType = { | |||
| "darwin": new DirectGameRunner(), | |||
| } | |||
| }, | |||
| [StorePlatform.PC_GAME_PASS]: { | |||
| [PackageLoader.BEPINEX]: { | |||
| "win32": new DirectGameRunner(), | |||
There was a problem hiding this comment.
I don't think these should be calling DirectGameRunner as we want to execute gamelaunchhelper.exe right?
A separate runner would be better XboxGamePassGameRunner (probably?) which instead of calling the first found executable in the GameManager.ts executables list (like DirectGameRunner does), it'd instead look for and call the gamelaunchhelper executable.
We also wouldn't need to declare the other executable names now. Although this is all worth making sure that args are passed through to the game when calling that executable.
Also a minor thing but since game pass isn't available on neither Linux nor MacOS, I'd say you don't need them defined. We can add that at a later date if necessary.
| @@ -114,6 +122,11 @@ const RESOLVERS: ResolverType = { | |||
| "linux": new DRMFreeDirectoryResolver(), | |||
| "darwin": new DRMFreeDirectoryResolver() | |||
| }, | |||
| [StorePlatform.PC_GAME_PASS]: { | |||
| "win32": new XGPDirectoryResolver(), | |||
| "linux": new DRMFreeDirectoryResolver(), | |||
There was a problem hiding this comment.
Same minor thing here about unnecessary definitions
|
Sorry for the long wait time for getting around to this PR. I'm generally only available during weekends for them |
Not sure about the platform naming, feel free to edit it.