Doesn't work with ember-cli@2.9.1 and ember-cli-postcss #178
Comments
|
@buschtoens what's the error that you are getting..? There is no pod-styles.css that get's generated. You'll have to import it into your current app stylesheet. |
|
@buschtoens just released a none beta 0.2.1 version. Please check it out and see if it fixes your issues. Also updated the wiki to with better instructions. |
|
We're using postcssOptions: {
compile: {
enabled: true,
plugins: [
{ module: require('postcss-easy-import') },
{ module: require('postcss-nested-ancestors') },
{ module: require('postcss-nested') },
{
module: require('postcss-simple-vars'),
options: { silent: true }
},
{ module: require('postcss-each') },
{ module: require('postcss-for') },
{ module: require('precss') },
{
module: require('postcss-cssnext'),
options: {
features: {
customProperties: { strict: false }
}
}
}
]
}
}An excerpt from our /* ember-component-css */
@import "pod-styles.css";
/* Print specific styles */
@import "print.css";
My understanding was that This did work prior to upgrading to However now,
These are our dependencies: |
|
ok. @buschtones i'll take a look at it in the morning.. |
|
Thanks a bunch. :) |
|
This is probably gonna come up so I gave it a shot right away. Switching from postcssOptions: {
compile: { enabled: false },
filter: {
enabled: true,
plugins: [
{ module: require('postcss-import') },
{ module: require('postcss-nested-ancestors') },
{ module: require('postcss-nested') },
{
module: require('postcss-simple-vars'),
options: { silent: true }
},
{ module: require('postcss-each') },
{ module: require('postcss-for') },
{ module: require('precss') },
{
module: require('postcss-cssnext'),
options: {
features: {
customProperties: { strict: false }
}
}
}
]
}
}Also doesn't work with |
|
it looks like for some reason when the |
|
I ran into this issue with ember-cli-stylus as well. Removing this line from the package.json file with a npm postinstall hook fixes it so I assume it would work with other pre-processors. I would make a PR to remove the lines but I assume they were added for a reason. |
|
@jakesjews the issue with ember-cli-stylus might be that it doesn't adds in the registry in the include method, rather then the The issue with postcss and plain css files, is a little different. I locally rewrote the plugin, and was only able to get it to work if I added an additional allowed extension for the plugin. So I haven't isolated what has changed in 2.9 to make that happen yet. But it appears that just removing the before clause didn't fix that issue. |
|
@buschtoens @jakesjews So.. oddly enought.. If you add in setupPreprocessorRegistry: function(type, registry) {
registry.add('css', {
ext: ['dummy'],
toTree: function(tree) {
return tree;
}
})
},into the |
|
but apparently if |
|
Using v0.2.2 I get the following message: Adding your code snippet to a dummy addon indeed fixes this. I published this pseudo-addon here for the convenience of others that might run into this: buschtoens/fix-ember-component-css So would you consider this a bug in ember-cli and not ember-component-css? If not, would you mind reopening this issue? |
|
@buschtoens That warning message was added to notify people that they have not yet created any component styles yet. Maybe it's extraneous? And ya, i'll reopen the issue. You mind changing the title to specify that this is only for postcss? |
|
And it might be a bug in ember-cli, but until a proper solution is found, we should keep it open. |
buschtoens
changed the title
|
after update to I see The Broccoli Plugin: [StylusCompiler] failed with:
|
|
@ihomp is this in an app or a addon? |
|
app |
|
@ihomp ok. i'm away away for the weekend, but will look at in monday. here's a base sample app that i have set up with it working, it's only scss though. https://github.com/webark/ecc-app-test there's some acceptance tests for stylus in this addon, but it's using a custom addon for all the css extensions, and not ember cli stylus. Maybe there's a different file structure that you have that isn't accounted for..? Anyway, wish i could do more from my phone.. :/ but that's all i have till i'm at a computer again.. |
|
I'm also getting the same errors. I just upgraded to I'm not using |
|
@denchen ya.. I haven't been able to track that down.. If you read above you can see why.. you should be able to use #178 (comment) the solution from that comment above. |
|
I've deleted the solution #178 (comment) didn't work for me... |
|
@ihomp so it looks like after @jakesjews PR was merged, a release was never cut for npm. If you use the master branch of ember-cli-stylus it will work. I added a branch to my test https://github.com/webark/ecc-app-test/tree/stylus-example that has it working. @drewcovi you think we could get a npm release cut of |
|
In the meantime we have a fork eflex-ember-cli-stylus which has the fix in it with version 1.0.2 |
|
Thanks for help @webark ! |
|
@webark npm release cut thanks everyone :) |
|
Hi, I can't seen to get the fix in #178 (comment) to work. First, I'm not sure it got installed correctly: Is that WARNING expected? I tried to run
Which is this line of code: I'm using ember-cli@2.11.0 and ember-component-css@0.2.3 along with ember-cli-postcss@3.0.6 and a bunch of PostCSS plugins. |
|
@denchen you need to upgrade ember-component-css . They made the |
|
@webark Ah, okay, upgrading ember-component-css did the trick, and my app is working. Just curious, is there any progress on a proper fix? |
|
@denchen I've been swapped with non work stuff for the past while, so haven't been able to spend much cycles on figuring out what's going on. For some reason the "treeForStyles" doesn't get added to the final build tree unless there is an additional style extension then just CSS. Haven't been able to track it down in the short time i've been able to spend looking at it. You could maybe ask around in some of the ember-cli channels on the ember slack if you want. Someone there might know. |
|
So.. 🐑 this was kind of a bug in our code all along. Apparently, with glob (which has terribly poor documentation around it who's knowledge appears to have been cargo culted from one place to another) a "set" can't have only one item in it. So I just am always adding a comma on to the end of the set, which, in the eyes of glob, adds another empty item. anyhow.. @buschtoens @denchen this should be fixed by #208 and we will no longer need @buschtoens addon. If it isn't, please feel free to reopen. Sorry for the inconvenience of this issue. |
|
@buschtoens and @denchen 0.2.10 has been released. Feel free to give it a try. |
# Change Log All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines. <a name="0.3.7"></a> ## [0.3.7](v0.3.6...v0.3.7) (2017-11-02) ### Features * **manifest ordering:** updated broccoli style manifest to now have the order of files in the manifest be sorted first by depth, then by alphanumeric ([fd710bf](fd710bf)) <a name="0.3.6"></a> ## [0.3.6](v0.3.5...v0.3.6) (2017-11-01) <a name="0.3.5"></a> ## [0.3.5](v0.3.4...v0.3.5) (2017-07-31) ### Bug Fixes * **component name parsing:** only switching out the word 'component/' if it is what starts the path, not for nest options. This should be revisited with unification Closes [#236](#236) ([54e087e](54e087e)) <a name="0.3.4"></a> ## [0.3.4](v0.3.3...v0.3.4) (2017-06-01) ### Bug Fixes * **ensure environment:** getting the 'root host', and using a shim if the find host method isn't present, Closes [#231](#231) ([09fa5ec](09fa5ec)) <a name="0.3.3"></a> ## [0.3.3](v0.3.2...v0.3.3) (2017-04-24) <a name="0.3.2"></a> ## [0.3.2](v0.3.1...v0.3.2) (2017-04-05) ### Bug Fixes * **style manifest:** updated to new brocoli-style-mainifest properties that are more explicit ([5e848ca](5e848ca)) ### Features * **optimization:** ability to use terse class names to reduce css size ([d53ead8](d53ead8)) <a name="0.3.1"></a> ## [0.3.1](v0.3.0...v0.3.1) (2017-03-30) ### Bug Fixes * **npm dependencies:** published what was being used to compile multiple differnt css preprocessors into one. closes [#221](#221) ([a060942](a060942)) <a name="0.3.0"></a> # [0.3.0](v0.2.12...v0.3.0) (2017-02-25) ### Features * **extensible identifier:** moved the generation of the namespace identifier and if the class should be added to a mixin for easier extensibility ([e3c627b](e3c627b)) <a name="0.2.12"></a> ## [0.2.12](v0.2.11...v0.2.12) (2017-02-24) ### Bug Fixes * **description:** removed pod specificity ([16eae3b](16eae3b)) * **scss @ rules:** now allowing namespaceing of rules deinfed inside of a scss @ for rule. Fixes [#216](#216) ([6840c5e](6840c5e)) <a name="0.2.11"></a> ## [0.2.11](v0.2.10...v0.2.11) (2017-02-03) ### Bug Fixes * **documentation:** updated for readabitlity ([d354534](d354534)) <a name="0.2.10"></a> ## [0.2.10](v0.2.9...v0.2.10) (2017-01-26) ### Bug Fixes * **plain css:** Due to the odd nature of 'glob', you can't have a set of just one item. ([fd0d770](fd0d770)), closes [#178](#178) [#204](#204) <a name="0.2.9"></a> ## [0.2.9](v0.2.8...v0.2.9) (2017-01-16) ### Bug Fixes * **nested addons:** no longer switching to the parent app so that addon's specific settings can be used ([849a72d](849a72d)) <a name="0.2.8"></a> ## [0.2.8](v0.2.7...v0.2.8) (2016-12-14) <a name="0.2.7"></a> ## [0.2.7](v0.2.6...v0.2.7) (2016-12-01) ### Bug Fixes * **namespacing:** no longer namespacing children of @ rules ([489f23f](489f23f)), closes [#191](#191) <a name="0.2.6"></a> ## [0.2.6](v0.2.5...v0.2.6) (2016-12-01) ### Bug Fixes * **ember-2.11:** moving to concatenating and reassigning the classnames in case a classname is already in the array before the init call per [@rwjblue](https://github.com/rwjblue) suggestion ([40113e6](40113e6)) <a name="0.2.5"></a> ## [0.2.5](v0.2.4...v0.2.5) (2016-12-01) ### Bug Fixes * **ember-2.11:** now not pushing to the frozen classnames property, but reasigning it ([63274c0](63274c0)) <a name="0.2.4"></a> ## [0.2.4](v0.2.3...v0.2.4) (2016-11-22) <a name="0.2.3"></a> ## [0.2.3](v0.2.2...v0.2.3) (2016-11-15) <a name="0.2.2"></a> ## [0.2.2](v0.2.1...v0.2.2) (2016-11-05)
I am using the
0.2.0-beta.4version. It seems that thepod-styles.cssis not generated.The text was updated successfully, but these errors were encountered: