Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Class names not correct #231

Closed
RobbieTheWagner opened this issue May 4, 2017 · 14 comments
Closed

Class names not correct #231

RobbieTheWagner opened this issue May 4, 2017 · 14 comments

Comments

@RobbieTheWagner
Copy link

RobbieTheWagner commented May 4, 2017 •
edited
Loading

When I run things locally, it all works great and I have things like __item-square__b73ce as my class name in the HTML and CSS. However, when I deploy it, or consume my addon that uses this, __item-square__b73ce becomes just __b73ce in the HTML but it stays __item-square__b73ce in the CSS, so the styles are never applied.

This seems to be related to the terseClassNames option. It would appear that option takes effect in the HTML, but the CSS does not respect that option.
@webark
Copy link
Owner

webark commented May 4, 2017

@rwwagner90 by default the "terseClassNames" is decided based on the environment. It sounds like your app is getting rebuilt in a production mode, but your css didn't get reprocessed..?

https://github.com/ebryn/ember-component-css/blob/master/index.js#L86
seems like something's confused there? If you are doing something special, you should be able to set that in your environment.js

@RobbieTheWagner
Copy link
Author

@webark shouldn't this addon ensure the html and css are both processed and correct?

@RobbieTheWagner
Copy link
Author

@webark where does this issue stand? I remember you were going to look into it, but I forget where we left off.

@webark
Copy link
Owner

webark commented May 30, 2017

been hopping around recently, so I haven't had time to look into it, sorry. I think I remember you having a reproducible repo with it? And I think there might have been something where you where coercing the environment so that the build and runtime environments where different? You mind linking that repo here and I'll dig in some more.

@RobbieTheWagner
Copy link
Author

No problem @webark! Appreciate all you have been doing 😄 . Essentially, if you use ECC in an addon, then consume that addon in an app, no styles are ever pulled in. Happens with all addons. So if you build the dummy app in the addon, no styles come through, and if you install the addon into a full fledged app, no styles come through either.

@webark
Copy link
Owner

webark commented May 31, 2017

wha..??!! @rwwagner90 we're using multiple addons with styles that are working as expected.

@webark
Copy link
Owner

webark commented May 31, 2017

i can update my existing addon example to the latest and post it here.

@RobbieTheWagner
Copy link
Author

@webark the addons and apps must both have ECC 0.3.3, and it does not pull the styles in. It was an issue in every single one of my apps and addons when building the dummy app or when consuming the addon in an actual app.

@webark
Copy link
Owner

webark commented May 31, 2017

@rwwagner90 https://github.com/webark/ecc-app-test looks like it's working fine.

@webark
Copy link
Owner

webark commented May 31, 2017

@rwwagner90 are you linking your addons locally..? currently, if you have a "physical" ember-component-css in an addon's node_modules, and in the app's node_modules, you will run into issues.

@RobbieTheWagner
Copy link
Author

@webark I am not doing any linking. ECC is in deps in all my addons, as is ember-cli-sass usually, and if I build the dummy app, no styles and if I install the addons with ember install my-addon no styles.

@RobbieTheWagner
Copy link
Author

This is the addon that is for sure does not work in https://github.com/shipshapecode/ember-3d-folding-panel/blob/master/package.json

@webark
Copy link
Owner

webark commented May 31, 2017

@rwwagner90 did you try the app I linked? I feel something is going wrong.. but I don't know where to go now.. do you have an example?

@webark webark mentioned this issue Jun 1, 2017
Merged
webark added a commit that referenced this issue Jun 1, 2017
@webark
fix(ensure environment): getting the 'root host', and using a shim if…
09fa5ec 
… the find host method isn't present, Closes #231
@webark
Copy link
Owner

webark commented Jun 1, 2017

@rwwagner90 released 0.3.4

webark added a commit that referenced this issue Nov 2, 2017
@webark
Update CHANGELOG.md
92e74fc 
# Change Log

All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.

<a name="0.3.7"></a>
## [0.3.7](v0.3.6...v0.3.7) (2017-11-02)


### Features

* **manifest ordering:** updated broccoli style manifest to now have the order of files in the manifest be sorted first by depth, then by alphanumeric ([fd710bf](fd710bf))



<a name="0.3.6"></a>
## [0.3.6](v0.3.5...v0.3.6) (2017-11-01)



<a name="0.3.5"></a>
## [0.3.5](v0.3.4...v0.3.5) (2017-07-31)


### Bug Fixes

* **component name parsing:** only switching out the word 'component/' if it is what starts the path, not for nest options. This should be revisited with unification Closes [#236](#236) ([54e087e](54e087e))



<a name="0.3.4"></a>
## [0.3.4](v0.3.3...v0.3.4) (2017-06-01)


### Bug Fixes

* **ensure environment:** getting the 'root host', and using a shim if the find host method isn't present, Closes [#231](#231) ([09fa5ec](09fa5ec))



<a name="0.3.3"></a>
## [0.3.3](v0.3.2...v0.3.3) (2017-04-24)



<a name="0.3.2"></a>
## [0.3.2](v0.3.1...v0.3.2) (2017-04-05)


### Bug Fixes

* **style manifest:** updated to new brocoli-style-mainifest properties that are more explicit ([5e848ca](5e848ca))


### Features

* **optimization:** ability to use terse class names to reduce css size ([d53ead8](d53ead8))



<a name="0.3.1"></a>
## [0.3.1](v0.3.0...v0.3.1) (2017-03-30)


### Bug Fixes

* **npm dependencies:** published what was being used to compile multiple differnt css preprocessors into one. closes [#221](#221) ([a060942](a060942))



<a name="0.3.0"></a>
# [0.3.0](v0.2.12...v0.3.0) (2017-02-25)


### Features

* **extensible identifier:** moved the generation of the namespace identifier and if the class should be added to a mixin for easier extensibility ([e3c627b](e3c627b))



<a name="0.2.12"></a>
## [0.2.12](v0.2.11...v0.2.12) (2017-02-24)


### Bug Fixes

* **description:** removed pod specificity ([16eae3b](16eae3b))
* **scss @ rules:** now allowing namespaceing of rules deinfed inside of a scss @ for rule. Fixes [#216](#216) ([6840c5e](6840c5e))



<a name="0.2.11"></a>
## [0.2.11](v0.2.10...v0.2.11) (2017-02-03)


### Bug Fixes

* **documentation:** updated for readabitlity ([d354534](d354534))



<a name="0.2.10"></a>
## [0.2.10](v0.2.9...v0.2.10) (2017-01-26)


### Bug Fixes

* **plain css:** Due to the odd nature of 'glob', you can't have a set of just one item. ([fd0d770](fd0d770)), closes [#178](#178) [#204](#204)



<a name="0.2.9"></a>
## [0.2.9](v0.2.8...v0.2.9) (2017-01-16)


### Bug Fixes

* **nested addons:** no longer switching to the parent app so that addon's specific settings can be used ([849a72d](849a72d))



<a name="0.2.8"></a>
## [0.2.8](v0.2.7...v0.2.8) (2016-12-14)



<a name="0.2.7"></a>
## [0.2.7](v0.2.6...v0.2.7) (2016-12-01)


### Bug Fixes

* **namespacing:** no longer namespacing children of @ rules ([489f23f](489f23f)), closes [#191](#191)



<a name="0.2.6"></a>
## [0.2.6](v0.2.5...v0.2.6) (2016-12-01)


### Bug Fixes

* **ember-2.11:** moving to concatenating and reassigning the classnames in case a classname is already in the array before the init call per [@rwjblue](https://github.com/rwjblue) suggestion ([40113e6](40113e6))



<a name="0.2.5"></a>
## [0.2.5](v0.2.4...v0.2.5) (2016-12-01)


### Bug Fixes

* **ember-2.11:** now not pushing to the frozen classnames property, but reasigning it ([63274c0](63274c0))



<a name="0.2.4"></a>
## [0.2.4](v0.2.3...v0.2.4) (2016-11-22)



<a name="0.2.3"></a>
## [0.2.3](v0.2.2...v0.2.3) (2016-11-15)



<a name="0.2.2"></a>
## [0.2.2](v0.2.1...v0.2.2) (2016-11-05)
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@webark @RobbieTheWagner