fix: editorconfig-linters dependency declaration scope #24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10, but requires some discussion imho.
Although I understand the intent behind direct dependency only on the
editorconfig-lint-api
and narrowing the scope of theeditorconfig-linters
, hard-coded addingmavenCentral()
causes issues in environments where manual repositories resolution is required: custom repositories resolution.Specifically, I think about environments where access to software repositories is restricted/proxied due to security reasons (described in #10, I have recent professional experience with such setup - becoming an industry standard I suppose).
Declaring linters package as
implementation
dependency looks like reasonable step:ec4j-maven-plugin